Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve default selection of combo box #3482

Closed
wbyoko opened this issue May 21, 2020 · 1 comment · Fixed by #3486
Closed

Improve default selection of combo box #3482

wbyoko opened this issue May 21, 2020 · 1 comment · Fixed by #3486
Labels
Package: Combo Box
Milestone
USWDS 2.7.1

Comments

@wbyoko
Copy link
Contributor

wbyoko commented May 21, 2020

The combo box selects the first item of the combo box when no placeholder is present. Could this be enhanced so that the list is only empty when no placeholder is present.
wbyoko added a commit that referenced this issue May 26, 2020
@wbyoko
3477 3482 Combo Box Data Attributes
61f7ca1 
update placeholder and default to data attributes
closes #3477
closes #3482
@wbyoko wbyoko mentioned this issue May 26, 2020
Merged
4 tasks
@thisisdano
Copy link
Member

Done in #3486

@thisisdano thisisdano added this to the USWDS 2.7.1 milestone Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: Combo Box
Projects
None yet
Milestone
USWDS 2.7.1
Development

Successfully merging a pull request may close this issue.

USWDS-3477 USWDS-3482 Combo Box Data Attributes uswds/uswds
2 participants
@wbyoko @thisisdano