New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-3479 Combo Box Subsequent Selection #3505
Merged
thisisdano
merged 25 commits into
10x-forms/combo-box-updates
from
10x-forms/3479-combobox-subsequent-selection
Jun 16, 2020
Merged
USWDS-3479 Combo Box Subsequent Selection #3505
thisisdano
merged 25 commits into
10x-forms/combo-box-updates
from
10x-forms/3479-combobox-subsequent-selection
Jun 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* specs * styles * manage pristine selection state
…combobox-subsequent-selection # Conflicts: # src/js/components/combo-box.js
toggle list update tabindex
…-combobox-subsequent-selection # Conflicts: # spec/unit/combo-box/combo-box-change-event.spec.js # spec/unit/combo-box/combo-box.spec.js # src/js/components/combo-box.js
…-combobox-subsequent-selection # Conflicts: # spec/unit/combo-box/combo-box.spec.js
…combobox-subsequent-selection # Conflicts: # spec/unit/combo-box/combo-box.spec.js # src/js/components/combo-box.js
* reset selection on tab
…ox-subsequent-selection # Conflicts: # spec/unit/combo-box/combo-box.spec.js
needed for subsequent selection
fire events on clear highlight selected item on open make sure shift+tab does nothing
after adding new buttons for toggle and clear. we need new functions to support disable and enable.
remove hover/active styles
Ben-Judy-Flexion
approved these changes
Jun 12, 2020
…combobox-subsequent-selection
…ox-subsequent-selection
This is a pretty extensive set of improvements! I have a couple questions related to this work, but I'm inclined to merge this now, and do any additional polish in a follow-up. |
thisisdano
approved these changes
Jun 16, 2020
This was referenced Jun 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation in Federalist
Description
closes #3479
This updates the ux of selecting an item after an item has been selected.
New and Updated Test Cases
Additional information - Screenshot images
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm test
and make sure the tests for the files you have changed have passed.