-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge IniAccessUnix.cpp into IniAccess.cpp #159
Conversation
そもそもWin32 APIへの直接の依存を無くしたいような気もしつつ,結局共通しているコードもあるのにファイルが分かれているのは取り回しにくいのでまとめたい,というやつです |
これかなりわかんないんだよな
|
inihの実装もこういうかんじなんで,単純にこのif文全く要らなさそうだな(そもそも意図が不明だが) s2e-core/src/Library/inih/cpp/INIReader.cpp Lines 22 to 29 in 3886c57
|
あーなるほど.このクラス,iniと言いつつCSVも読んでるからか.とはいえ |
|
多少修正も入れてしまいましたが,基本的には |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
丁寧にまとめてることを確認した
Overview
SSIA
Issue
Details
Write in detail.
Validation results
Link to tests or validation results.
Scope of influence
eg. The behavior of XX will be change.
Supplement
Write additional comments if you need.
Note
priority
label if possible.