Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Fix bug in GNSS satellite latitude calculation #230

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

ShingoNishimoto
Copy link
Contributor

Overview

Fix bug of latitude calculation in GNSSReceiver class.

Issue

  • Related issues

Details

The calculation of GNSS satellite latitude in GNSS receiver frame was wrong, which was arctan(z / r). So I modified it to \arctan(z / \sqrt{x^2 + y^2}).

Validation results

GNSS skyplot seems correct.
newplot (1)

Scope of influence

Users can get correct GNSS information from GNSSReceiver class.

Supplement

NA

Note

  • If there are related Projects, tie them together.
  • Assignees should be set if possible.
  • Reviewers should be set if possible.
  • Set priority label if possible.

Copy link
Member

@200km 200km left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正は問題ないと思います。
結果のプロットについて質問なのですが、同じ衛星軌道に見えるのに色が変わっているのは、受信機内の対応chが変わっているだけという理解で良いですか?

@ShingoNishimoto
Copy link
Contributor Author

はい,その通りです.ほんとは同じ衛星に対してプロットした方が分かりやすいんですが,ログの残し方的にめんどくさかったので一旦そうしてます.

@ShingoNishimoto ShingoNishimoto merged commit 13bbb06 into main Nov 19, 2022
@ShingoNishimoto ShingoNishimoto deleted the hotfix/fix_gnss_latitude_bug branch November 19, 2022 10:03
@200km 200km mentioned this pull request Nov 20, 2022
200km added a commit that referenced this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants