Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in GNSS satellite latitude calculation #229

Closed
wants to merge 1 commit into from

Conversation

ShingoNishimoto
Copy link
Contributor

Overview

Fix bug of latitude calculation in GNSSReceiver class.

Issue

  • Related issues

Details

The calculation of GNSS satellite latitude in GNSS receiver frame was wrong, which was arctan(z / r). So I modified it to \arctan(z / \sqrt{x^2 + y^2}).

Validation results

GNSS skyplot seems correct.
newplot (1)

Scope of influence

Users can get correct GNSS information from GNSSReceiver class.

Supplement

NA

Note

  • If there are related Projects, tie them together.
  • Assignees should be set if possible.
  • Reviewers should be set if possible.
  • Set priority label if possible.

@ShingoNishimoto ShingoNishimoto added the bug Something isn't working label Nov 19, 2022
@ShingoNishimoto ShingoNishimoto self-assigned this Nov 19, 2022
@200km
Copy link
Member

200km commented Nov 19, 2022

@ShingoNishimoto ありがとうございます!バグ修正ということで、hotfixで処理したいです。
mainからhotfix/hogeブランチを切って、mainに対してマージするという形でPRを出してもらえると助かります。
gcc環境でのビルドエラーは僕の方で確認しておきます。

@200km
Copy link
Member

200km commented Nov 19, 2022

Build on LinuxのエラーはPlot GS visibilityででている。
Warning: Python 3.8 was not found on your system... Neither 'pyenv' nor 'asdf' could be found to install Python.

とりあえず、本件はhotfixですすめるので、mainマージにすればこのバグは関係なくなるけど、別途対応が必要にはなる。

https://github.com/ut-issl/s2e-core/actions/runs/3502777067/jobs/5867395295

@ShingoNishimoto
Copy link
Contributor Author

#230 こちらに作りました.よろしくお願いします.

@200km 200km mentioned this pull request Nov 19, 2022
@200km
Copy link
Member

200km commented Nov 19, 2022

issue立てたので、このPRは閉じる

@200km 200km closed this Nov 19, 2022
@200km 200km deleted the feature/modify_gnss_latitude branch November 19, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants