Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cspice build #73

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Reduce cspice build #73

merged 3 commits into from
Apr 4, 2022

Conversation

sksat
Copy link
Collaborator

@sksat sksat commented Apr 4, 2022

Overview

Reduce unneeded build of ExtLibraries/cspice for speed up ExtLibraries build.

Issue

  • Related issues

Details

Write in detail.

Validation results

Link to tests or validation results.

Scope of influence

eg. The behavior of XX will be change.

Supplement

Write additional comments if you need.

Note

  • If there are related Projects, tie them together.
  • Assignees should be set if possible.
  • Reviewers should be set if possible.
  • Set priority label if possible.

@sksat sksat added enhancement New feature or request tools labels Apr 4, 2022
@sksat sksat self-assigned this Apr 4, 2022
@sksat
Copy link
Collaborator Author

sksat commented Apr 4, 2022

これキャッシュミスすべきなのにキャッシュヒットしてるな.hashFiles()の書き方がダメっぽい.

@sksat
Copy link
Collaborator Author

sksat commented Apr 4, 2022

rebase

@sksat sksat force-pushed the feature/reduce-cspice-build branch from cbbf70e to 84fa442 Compare April 4, 2022 04:49
@sksat
Copy link
Collaborator Author

sksat commented Apr 4, 2022

これそもそもzipファイルの中にlib/cspice.lib, lib/csupport.lib転がってるからビルドする必要無いのでは???

@sksat sksat force-pushed the feature/reduce-cspice-build branch from 1cb900f to a027f58 Compare April 4, 2022 05:36
@sksat
Copy link
Collaborator Author

sksat commented Apr 4, 2022

あとで明示的にcspiceをビルドするオプションを入れてもいいかもしれない

@sksat sksat requested a review from meltingrabbit April 4, 2022 05:41
Copy link
Contributor

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sksat sksat merged commit 890c2bf into develop Apr 4, 2022
@sksat sksat deleted the feature/reduce-cspice-build branch April 4, 2022 05:43
@meltingrabbit
Copy link
Contributor

別PRでもいいが

@sksat
Copy link
Collaborator Author

sksat commented Apr 4, 2022

そもそもこれは./ExtLibraries/のCMakeで代替したい

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants