Fixed bug with similar suitepaths #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgebal
reviewed
Aug 26, 2017
source/core/ut_suite_manager.pkb
Outdated
| @@ -424,7 +424,8 @@ create or replace package body ut_suite_manager is | |||
| end clean_paths; | |||
|
|
|||
| procedure skip_by_path(a_suite in out nocopy ut_suite_item, a_path varchar2) is | |||
| c_root constant varchar2(32767) := replace(regexp_substr(a_path, '[A-Za-z0-9$#_]+'), '$', '\$'); | |||
| --c_root constant varchar2(32767) := replace(regexp_substr(a_path, '[A-Za-z0-9$#_]+'), '$', '\$'); | |||
There was a problem hiding this comment.
Do we need to keep this commented code?
source/core/ut_suite_manager.pkb
Outdated
| @@ -441,7 +442,7 @@ create or replace package body ut_suite_manager is | |||
|
|
|||
| l_item_name := l_item.name; | |||
| --l_item_name := regexp_substr(l_item_name,'[A-Za-z0-9$#_]+$'); -- temporary fix. seems like suite have suitepath in object_name | |||
There was a problem hiding this comment.
Can we have the commented code removed? This temp filx is there since quite some time ;)
| @@ -132,6 +132,13 @@ create or replace package test_suite_manager is | |||
| --%test | |||
| --%disabled | |||
| --procedure IncludesPackagesWithSutePath; | |||
|
|
|||
| --%test | |||
There was a problem hiding this comment.
Can you provide a description for the test?
jgebal
approved these changes
Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #468
Fixed bug with similar suite paths