Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make index.html slideshow dynamic #54

Closed
rolsanmordua opened this issue Aug 3, 2018 · 4 comments
Closed

Make index.html slideshow dynamic #54

rolsanmordua opened this issue Aug 3, 2018 · 4 comments
Assignees

Comments

@rolsanmordua
Copy link
Contributor

Keep in mind...

  • Banner should be left hardcoded to compensate for loading time of DR (should happen before first transition finishes)
  • JS has to be loaded before main.js
@rolsanmordua rolsanmordua self-assigned this Aug 3, 2018
@ChiaHuaLu
Copy link
Contributor

Simply including slideshow js before main js will probably not be enough. Slideshow.js will use async requests to get data from google sheet. Thus, main.js might have already finished when slideshow.js actually runs.

Look into using maybe jquery so we can make main.js's slideshow code wait

@ChiaHuaLu
Copy link
Contributor

Maybe we can use .when() and .register() methods to make main.js's slideshow code wait until slideshow.js is ready

@ChiaHuaLu
Copy link
Contributor

Jquery sounds intimidating but isnt really that bad. It expands what you can do with javascript.

With jquery, you can use $('#imgId').src='http://...'; to change an image's source. Whereas without jquery, you would do the same thing as
document.getElementById('imgId').src='http://...';

You can select all elements of a class with $('.className') and do something to it.

Jquery also lets you do things you cant do before. Look up jquery API. An example would be $('#photo').fadeIn(100); to fade in an image over 1 second

@rolsanmordua
Copy link
Contributor Author

We don't update this part of the page enough to justify Dynamic Resource implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants