test merge of joq/unit_tests for Travis #70
Conversation
|
I was expecting that failure. We can't declare our dependencies on the segway packages because they are not released. |
|
The last commit should also fail, but this time due to roslaunch check errors. |
|
This is working now, and can probably be merged after the IJCAI demo next Tuesday. |
|
@piyushk: please review |
| roslaunch_add_file_check(launch/includes/auxiliary.segbot_v1.no_sensors.launch.xml) | ||
| roslaunch_add_file_check(launch/segway_base.launch) | ||
| roslaunch_add_file_check(launch/includes/auxiliary.segbot_v2.launch.xml) | ||
| #roslaunch_add_file_check(launch/includes/auxiliary.segbot_v3.launch.xml) |
There was a problem hiding this comment.
you could probably add this in. This launch file doesn't have a dependency on the missing v3 packages.
There was a problem hiding this comment.
It's still there, I just sorted it earlier in the list (line 33), with the other launch/ folder contents.
|
looks really good @jack-oquin! Thanks for pushing it through. I had one minor comment. |
|
I don't think this will break anything, and it fixes some test failures. Since enabling Travis for this repository causes errors for any other merges, I guess I'll go ahead an merge this now. |
xref: utexas-bwi/bwi#38