Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a minor BUG in the PID controller #128

Closed
TakatoOvO opened this issue Apr 17, 2023 · 2 comments
Closed

a minor BUG in the PID controller #128

TakatoOvO opened this issue Apr 17, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@TakatoOvO
Copy link

I would like to express my gratitude to you and your team for providing such a practical suite!

While reviewing the code in pid.py, I have encountered a possible minor issue. Should the variable 'cur_ang_vel' in line 100 be assigned as 'cur_ang_vel=np.array([0, obs[5], 0])' rather than the current assignment of 'np.array([0, obs[4], 0])'?

Could you please check if any modification is necessary?

Also, I was wondering if there are any plans to further improve the CBF controller, which currently seems to only apply to the cartpole system.

I am eagerly looking forward to your future work!

@JacopoPan JacopoPan added the bug Something isn't working label Apr 20, 2023
@Federico-PizarroBejarano
Copy link
Contributor

@Takato20 concerning the CBF, we do have some ideas about extending it but we have no hard plans currently. There is a PR for a CBF that uses learning (#49 implementing this paper: https://arxiv.org/abs/2204.03801), but I believe it also only applies to the cartpole

@TakatoOvO
Copy link
Author

Thank you for your reply ,and look forward to your future work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants