Linting #130
Merged
Linting #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Federico-PizarroBejarano
added
the
documentation
JacopoPan
approved these changes
May 8, 2023
JacopoPan
approved these changes
May 8, 2023
adamhall
approved these changes
May 8, 2023
| Gamma_inv = torch.diag_embed(1/Gamma) | ||
| # Todo: Should inverse be used here instead? pinverse was more stable previsouly. | ||
| Sigma_inv = K_zind_zind + K_x_zind.transpose(1,2) @ Gamma_inv @ K_x_zind | ||
| Sigma = torch.pinverse(K_zind_zind + K_x_zind.transpose(1,2) @ Gamma_inv @ K_x_zind) |
There was a problem hiding this comment.
Can we keep these lines? Sigma is useful for debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of linting using a combination of automatic tools and standardizing our documentation manually. There is still a lot of work documentation-wise since entire files have no docstrings, but that can be done later now that the structure is standardized. Hard to ensure I haven't broken something since there are no experiments for many of the controllers, and the code is very obfuscated in some files.