Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SonarCloud issues #883

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Fix SonarCloud issues #883

merged 3 commits into from
Apr 18, 2023

Conversation

utilForever
Copy link
Owner

This revision includes:

  • Fix SonarCloud issues
    • Check "rhs" for equality to "this" before proceeding with the assignment
    • Potential leak of memory pointed to by field '_M_pi'
    • Access to field 'game' results in a dereference of a null pointer (loaded from field 'm_owner')

@utilForever
fix: Correct SonarCloud issue
3a5a0c7 
- Check "rhs" for equality to "this" before proceeding with the assignment.
@utilForever
fix: Correct SonarCloud issues
8d47b89 
- Potential leak of memory pointed to by field '_M_pi'
@utilForever
fix: Correct SonarCloud issue
9560500 
- Access to field 'game' results in a dereference of a null pointer (loaded from field 'm_owner')
@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@utilForever utilForever merged commit e2c125b into main Apr 18, 2023
@utilForever utilForever deleted the fix-code branch April 18, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@utilForever