Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gauge vec for counting snapshots created/removed per volume #4

Merged
merged 2 commits into from
Oct 3, 2017

Conversation

martinsirbe
Copy link
Contributor

No description provided.

Copy link
Contributor

@JamieAP JamieAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait no. There are way too many VolumeIDs for this to be sensible,

Do not use labels to store dimensions with high cardinality (many different label values), such as user IDs, email addresses, or other unbounded sets of values.

https://prometheus.io/docs/practices/naming/

@jakekeeys
Copy link
Contributor

jakekeeys commented Oct 3, 2017

there should be tags on the volume you can use

@jakekeeys
Copy link
Contributor

image

@jakekeeys
Copy link
Contributor

would be good to have both of those in the vec

@martinsirbe martinsirbe merged commit 4832fe2 into master Oct 3, 2017
@martinsirbe martinsirbe deleted the add-prometheus-counters branch October 3, 2017 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants