Add rate limiting for incoming requests #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements 2 separate rate limiters: - One per requests coming from peer that has an open stream to the server - One for all the incoming requests to the server. The first one will limit bad actors, while the second one can be used to limit max memory and avoid throttling Maybe the defaults are a bit shy and can re-evaluate after some time running on dev environments. Also, this improves logging by adding peers IPs on stream requests.
george-angel
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements 2 separate rate limiters:
Maybe the defaults are a bit shy and can re-evaluate after some time running on dev environments.
Also, this improves logging by adding peers IPs on stream requests.