Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close issue #9: Edit transaction feature added #10

Merged
merged 5 commits into from Oct 15, 2019

Conversation

vitokhangnguyen
Copy link
Contributor

This pull request closes issue #9.

The syntax for the new command is as following and documented in README.md

budget edit [income | expense] [line_index] [new_transsaction]

When a date is not specified in new_transasction, the original date is used. When a date is specified, the new date is used. The monthly spreadsheet's ID will be identified based on the month in the transaction date.

The budget log command now displays line index to be used in editing transaction:

Oct Expense Log
===============================================================================      
   1   08/09/2000    $1,500.00    Rent                                Home
   2   13/10/2019       $35.00    Groceries                           Home
   3   13/10/2019        $5.00    Pizza                               Food
   4   13/10/2019        $5.00    Pizza                               Food

Oct Income Log
===============================================================================      
   1   08/09/2000    $2,000.00    Paycheck                            Paycheck       
   2   13/10/2019       $75.00    Tax Return                          Other
   3   13/10/2019      $100.00    Scholarship                         Bonus
   4   13/10/2019      $100.00    Scholarship                         Bonus
   5   13/10/2019       $75.00    Tax Return                          Other

Copy link
Owner

@utkuufuk utkuufuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great so far 👍

I just have a few minor comments.

.gitignore Outdated Show resolved Hide resolved
budget/__main__.py Show resolved Hide resolved
budget/__main__.py Outdated Show resolved Hide resolved
budget/__main__.py Outdated Show resolved Hide resolved
budget/__main__.py Outdated Show resolved Hide resolved
budget/__main__.py Outdated Show resolved Hide resolved
@vitokhangnguyen
Copy link
Contributor Author

I have adjusted the code. Please review it when you can.

Update .gitignore to exclude config.json and venv

Add line index to `budget log`

add basic edit feature

add constraint check and date adjustment

Document changes in README.md

Improve code for edit feature

Improve edit message
@utkuufuk
Copy link
Owner

Great work thank you 👍
I just made some minor adjustments.

@utkuufuk utkuufuk merged commit 1637431 into utkuufuk:master Oct 15, 2019
@vitokhangnguyen
Copy link
Contributor Author

I am happy to contribute. If you don't mind, I think deleting a transaction can be a good feature, too. If you want, please open an issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants