Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cfg_if for a cleaner sourceset #147

Closed
kinggoesgaming opened this issue Feb 14, 2018 · 1 comment
Closed

Use cfg_if for a cleaner sourceset #147

kinggoesgaming opened this issue Feb 14, 2018 · 1 comment
Assignees
@kinggoesgaming
Milestone
0.6.2

Comments

@kinggoesgaming
Copy link
Member

This should help in reading the sources a bit easier, as it helps in reading attributes in a more logical sense.

Reference: #124
@kinggoesgaming kinggoesgaming added this to the Post 0.6.0 milestone Feb 14, 2018
@kinggoesgaming kinggoesgaming modified the milestones: 0.6.1, 0.7.0 Mar 1, 2018
@kinggoesgaming kinggoesgaming mentioned this issue Mar 11, 2018
Merged
4 tasks
bors bot added a commit that referenced this issue Mar 14, 2018
@bors
Merge #167
e7eb8b0 
167: Use cfg-if to create logical feature gate implementations r=Dylan-DPC a=kinggoesgaming

<!--
    As we are working towards a stable version of uuid, we require that you 
    open an issue, before submitting a pull request. If the pull request is 
    imcomplete, prepend the Title with WIP: 
-->

**I'm submitting a ...**
  - [ ] bug fix
  - [ ] feature enhancement
  - [ ] deprecation or removal
  - [x] refactor

# Description
`uuid` now adds `cfg-if` as a dependency.  With this, `#[cfg(..)]` implementations are easier to understand, as they can be handled in a more logical view because the macro allows us to `if` statements to make the checks more rustic at the source level

# Motivation
Understanding feature gate implementation becomes easier.

# Tests
The CI builds passing should be plenty.

# Related Issue(s)
#147
bors bot added a commit that referenced this issue Mar 14, 2018
@bors
Merge #167
5ca5ddd 
167: Use cfg-if to create logical feature gate implementations r=kinggoesgaming a=kinggoesgaming

<!--
    As we are working towards a stable version of uuid, we require that you 
    open an issue, before submitting a pull request. If the pull request is 
    imcomplete, prepend the Title with WIP: 
-->

**I'm submitting a ...**
  - [ ] bug fix
  - [ ] feature enhancement
  - [ ] deprecation or removal
  - [x] refactor

# Description
`uuid` now adds `cfg-if` as a dependency.  With this, `#[cfg(..)]` implementations are easier to understand, as they can be handled in a more logical view because the macro allows us to `if` statements to make the checks more rustic at the source level

# Motivation
Understanding feature gate implementation becomes easier.

# Tests
The CI builds passing should be plenty.

# Related Issue(s)
#147
bors bot added a commit that referenced this issue Mar 14, 2018
@bors
Merge #167
8b7f02f 
167: Use cfg-if to create logical feature gate implementations r=kinggoesgaming a=kinggoesgaming

<!--
    As we are working towards a stable version of uuid, we require that you 
    open an issue, before submitting a pull request. If the pull request is 
    imcomplete, prepend the Title with WIP: 
-->

**I'm submitting a ...**
  - [ ] bug fix
  - [ ] feature enhancement
  - [ ] deprecation or removal
  - [x] refactor

# Description
`uuid` now adds `cfg-if` as a dependency.  With this, `#[cfg(..)]` implementations are easier to understand, as they can be handled in a more logical view because the macro allows us to `if` statements to make the checks more rustic at the source level

# Motivation
Understanding feature gate implementation becomes easier.

# Tests
The CI builds passing should be plenty.

# Related Issue(s)
#147
@kinggoesgaming
Copy link
Member Author

forgot to tag it in PR #167

@kinggoesgaming kinggoesgaming modified the milestones: 0.7.0, 0.6.2 Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kinggoesgaming kinggoesgaming

Labels
None yet
Projects
None yet
Milestone
0.6.2
Development

No branches or pull requests
2 participants
@Dylan-DPC-zz @kinggoesgaming