Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split lib.rs into multiple files #124

Closed
kinggoesgaming opened this issue Feb 1, 2018 · 3 comments
Closed

Split lib.rs into multiple files #124

kinggoesgaming opened this issue Feb 1, 2018 · 3 comments
Assignees
@Dylan-DPC-zz
Projects
0.7.x
Milestone
0.7.0

Comments

@kinggoesgaming
Copy link
Member

kinggoesgaming commented Feb 1, 2018 •
edited

Currently lib.rs consists of ~1500 LoC and includes nearly everything written in the file.

A better way would be to have internal mods and export important [and maybe all] -> needs debate on structure
@kinggoesgaming kinggoesgaming added this to To Do in Uuid v1.0.0 Feb 3, 2018
@Dylan-DPC-zz Dylan-DPC-zz self-assigned this Feb 6, 2018
@radix radix closed this as completed Feb 8, 2018
@radix radix reopened this Feb 8, 2018
@radix
Copy link
Contributor

radix commented Feb 8, 2018

sorry, clicked the wrong button ;-)

@kinggoesgaming
Copy link
Member Author

I think a first step for this would be to break down the lib.rs into mods. If any renames are needed, a separate PR can be proposed and then this issue can be closed. (general plan)

@kinggoesgaming kinggoesgaming added this to the Post 0.6.0 milestone Feb 9, 2018
@kinggoesgaming kinggoesgaming mentioned this issue Feb 14, 2018
Closed
@Dylan-DPC-zz Dylan-DPC-zz modified the milestones: 0.6.1, 0.7.0 Feb 17, 2018
@kinggoesgaming kinggoesgaming mentioned this issue Mar 11, 2018
Closed
@kinggoesgaming kinggoesgaming mentioned this issue Mar 25, 2018
Merged
4 tasks
bors bot added a commit that referenced this issue Mar 25, 2018
@bors
Merge #182
80bf568 
182: move test Uuid creation functions into new module r=Dylan-DPC a=kinggoesgaming

**I'm submitting a ...**
  - [ ] bug fix
  - [ ] feature enhancement
  - [ ] deprecation or removal
  - [x] refactor

# Description
Refactor the `tests::new` and `tests::new2` functions into `test_util` module.

# Motivation
Part of the great refactor. Allows different tests in different modules access the test constructors for `Uuid`

# Tests
The tests are passing

# Related Issue(s)
#124
@kinggoesgaming kinggoesgaming mentioned this issue Mar 26, 2018
Merged
4 tasks
bors bot added a commit that referenced this issue Mar 26, 2018
@bors
Merge #185
0634126 
185: move slog implementation into its own module r=kinggoesgaming a=kinggoesgaming

**I'm submitting a ...**
  - [ ] bug fix
  - [ ] feature enhancement
  - [ ] deprecation or removal
  - [x] refactor

# Description
The slog impl and tests are moved into `slog_support` module

# Motivation
As part of the refactor effort, feature gated implementations need to be moved into their own modules.

# Tests
Current provided tests are passing

# Related Issue(s)
#124
@kinggoesgaming kinggoesgaming mentioned this issue Mar 27, 2018
Merged
4 tasks
bors bot added a commit that referenced this issue Mar 27, 2018
@bors
Merge #187
05a59d4 
187: Move namespaces into uuid::ns r=kinggoesgaming a=kinggoesgaming

**I'm submitting a ...**
  - [ ] bug fix
  - [ ] feature enhancement
  - [ ] deprecation or removal
  - [x] refactor

# Description
Moves `NAMESPACE_DNS`, `NAMESPACE_OID`, `NAMESPACE_URL` and `NAMESPACE_X500` into `uuid::ns` module. The namespaces are not exposed as part of the prelude, as people only may need one of the namespaces when they do need them.

# Motivation
Part of the refactor efforts

# Tests
Current tests are passing.

# Related Issue(s)
#124
@kinggoesgaming kinggoesgaming mentioned this issue Apr 1, 2018
Merged
4 tasks
bors bot added a commit that referenced this issue Apr 1, 2018
@bors
Merge #192
df4a426 
192: Refactor v1 implementation r=Dylan-DPC a=kinggoesgaming

**I'm submitting a ...**
  - [ ] bug fix
  - [ ] feature enhancement
  - [ ] deprecation or removal
  - [x] refactor

# Description
* Move v1 impl into `uuid::v1`
* Rename `UuidV1ClockSequence` -> `UuidClockSequence`
* Rename `UuidV1Context` -> `UuidContext`
* Added `UuidClockSequence`, `UuidContext` to the prelude

# Motivation
Part of the great refactor effort

# Tests
All tests passing, no new tests needed

# Related Issue(s)
#124
@kinggoesgaming kinggoesgaming mentioned this issue Apr 10, 2018
Merged
4 tasks
bors bot added a commit that referenced this issue Apr 13, 2018
@bors @kinggoesgaming
Merge #193
b1eac3d 
193: Refactor/core support r=Dylan-DPC a=kinggoesgaming

**I'm submitting a ...**
  - [ ] bug fix
  - [ ] feature enhancement
  - [ ] deprecation or removal
  - [x] refactor

# Description
* Refactor `prelude` items' core trait implementations. No breaking changes included.
* Add `<core|std>::fmt::Display` support for `UuidVariant`

# Motivation
Part of the grand refactor efforts

# Tests
<!-- How are these changes tested? -->
TODO

# Related Issue(s)
#124 


Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@kinggoesgaming kinggoesgaming mentioned this issue Apr 21, 2018
Merged
4 tasks
bors bot added a commit that referenced this issue Apr 21, 2018
@bors @kinggoesgaming
Merge #199
268f562 
199: move v5 impl into its own module r=Dylan-DPC a=kinggoesgaming

**I'm submitting a ...**
  - [ ] bug fix
  - [ ] feature enhancement
  - [ ] deprecation or removal
  - [x] refactor

# Description
Refactor the v5 impl into its own module

# Motivation
Part of the refactor process

# Tests
All passing

# Related Issue(s)
#124 


Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
This was referenced Apr 28, 2018
Closed
Merged
bors bot added a commit that referenced this issue Apr 29, 2018
@bors @kinggoesgaming
Merge #213
c0851c2 
213: provide adapter length constants r=Dylan-DPC a=kinggoesgaming

**I'm submitting a ...**
  - [ ] bug fix
  - [x] feature enhancement
  - [ ] deprecation or removal
  - [ ] refactor

# Description
* Add `adapter::UUID_HYPHENATED_LENGTH`, `adapter::UUID_SIMPLE_LENGTH` and `adapter::UUID_URN_LENGTH`
* Remove `::HYPHENATED_LENGTH` and `::SIMPLE_LENGTH`

# Motivation
Allow users to the adapter to determine the lengths to the adapters. Step 1 in the adapter refactor

# Tests
All current tests passing

# Related Issue(s)
#124, #212 

Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@kinggoesgaming kinggoesgaming mentioned this issue May 2, 2018
Merged
4 tasks
bors bot added a commit that referenced this issue May 3, 2018
@bors @kinggoesgaming
Merge #215
090a9e8 
215: refactor v3 implementation r=Dylan-DPC a=kinggoesgaming

Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>

<!--
    As we are working towards a stable version of uuid, we require that you 
    open an issue, before submitting a pull request. If the pull request is 
    imcomplete, prepend the Title with WIP: 
-->

**I'm submitting a ...**
  - [ ] bug fix
  - [ ] feature enhancement
  - [ ] deprecation or removal
  - [x] refactor

# Description
Move v3 implementation to the v3 module

# Motivation
Part of the grand refactor

# Tests
All tests, including v3 tests passing 

# Related Issue(s)
#124 


Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@kinggoesgaming kinggoesgaming mentioned this issue May 21, 2018
Closed
@kinggoesgaming kinggoesgaming mentioned this issue Jun 2, 2018
Merged
4 tasks
bors bot added a commit that referenced this issue Jun 26, 2018
@bors @kinggoesgaming
Merge #256
aa1cc48 
256: Refactor adapters r=Dylan-DPC a=kinggoesgaming

Currently in a hurry, will expand the description tomorrow or so.
Also these changes particularly around the `to_<adaptertype>` method names need discussion before merge

**I'm submitting a ...**
  - [ ] bug fix
  - [x] feature enhancement
  - [ ] deprecation or removal
  - [x] refactor

# Description
Refactors the adapters

# Motivation
One of the last steps in the great refactor

# Tests
Current tests pass.... More tests need to be added

# Related Issue(s)
#124


Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@kinggoesgaming kinggoesgaming added this to To do in 0.7.x Jul 24, 2018
@kinggoesgaming kinggoesgaming removed this from To Do in Uuid v1.0.0 Jul 31, 2018
@kinggoesgaming kinggoesgaming moved this from To do to In progress in 0.7.x Aug 14, 2018
@kinggoesgaming
Copy link
Member Author

This is now roughly complete, only some rough edges here and there left to sort out, which have issues of their own.

Closing

0.7.x automation moved this from In progress to Done Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
None yet
Projects
No open projects
0.7.x
  
Done
Milestone
0.7.0
Development

No branches or pull requests
3 participants
@radix @Dylan-DPC-zz @kinggoesgaming