Add a new trait, UuidV1ClockSequence which defines the interface for generating clock sequences.
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r generating clock sequences. * new_v1 now takes any implementor of UuidV1ClockSequence, instead of just UuidV1Context. * UuidV1Context implements UuidV1ClockSequence, but ignores the `seconds` and `nanoseconds` arguments.
radix
requested review from
Dylan-DPC-zz,
kinggoesgaming and
KodrAus
as code owners
Dylan-DPC-zz
approved these changes
Feb 6, 2018
kinggoesgaming
changed the title
UuidV1ClockSequence which defines the interface for generating clock sequences.UuidV1ClockSequence which defines the interface for generating clock sequences.
KodrAus
approved these changes
Feb 6, 2018
Dylan-DPC-zz
changed the title
UuidV1ClockSequence which defines the interface for generating clock sequences.UuidV1ClockSequence which defines the interface for generating clock sequences.
kinggoesgaming
changed the title
UuidV1ClockSequence which defines the interface for generating clock sequences.UuidV1ClockSequence which defines the interface for generating clock sequences.
Dylan-DPC-zz
changed the title
UuidV1ClockSequence which defines the interface for generating clock sequences.UuidV1ClockSequence which defines the interface for generating clock sequences.
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Feb 8, 2018
137: Add a new trait, `UuidV1ClockSequence` which defines the interface for generating clock sequences. r=Dylan-DPC a=radix * new_v1 now takes any implementor of UuidV1ClockSequence, instead of just UuidV1Context. * UuidV1Context implements UuidV1ClockSequence, but ignores the `seconds` and `nanoseconds` arguments. This takes a more conservative approach. No changes to the way UuidV1Context generates sequences, but now other people can implement their own clock-sequence generators. The nice thing is that *I think* this is entirely backwards compatible (which means that this didn't need to block 1.0). This is meant to address #106. It does not implement all the suggestions that it had, but it allows users to, and also allows us to add more implementations with different clock-sequence strategies in a backwards-compatible way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secondsandnanosecondsarguments.This takes a more conservative approach. No changes to the way UuidV1Context generates sequences, but now other people can implement their own clock-sequence generators.
The nice thing is that I think this is entirely backwards compatible (which means that this didn't need to block 1.0).
This is meant to address #106. It does not implement all the suggestions that it had, but it allows users to, and also allows us to add more implementations with different clock-sequence strategies in a backwards-compatible way.