Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sha1 to 0.5 #142

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Update sha1 to 0.5 #142

merged 1 commit into from
Feb 9, 2018

Conversation

kinggoesgaming
Copy link
Member

@kinggoesgaming kinggoesgaming commented Feb 8, 2018 •
edited

closes #141

@kinggoesgaming
changed(sha1): update sha1 to 0.5
5018051 
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@kinggoesgaming kinggoesgaming self-assigned this Feb 8, 2018
@kinggoesgaming kinggoesgaming added this to the 0.6.0 milestone Feb 8, 2018
@Dylan-DPC-zz
Copy link
Member

Kindly check if the repo has any breaking changes that affect us.

radix
radix approved these changes Feb 8, 2018
View reviewed changes
Copy link
Contributor

@radix radix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like sha1 did two things in 0.5:

  • add serde support (no effect on uuid)
  • bump rand to 0.4

The README for rand states that 0.4 "contains almost no breaking changes since the 0.3 release", and that it mostly just added new features.

@kinggoesgaming
Copy link
Member Author

I will check the changes in between the two versions of rand

@KodrAus
Copy link
Member

KodrAus commented Feb 9, 2018

I think we're safe either way here, because sha1 isn't a public dependency.

@kinggoesgaming
Copy link
Member Author

The only major one I see is the switch to JitterRNG for thread_local so this should be good

@Dylan-DPC-zz
Copy link
Member

bors: r+

bors bot added a commit that referenced this pull request Feb 9, 2018
@bors
Merge #142
9b1fb92 
142: Update sha1 to 0.5 r=Dylan-DPC a=kinggoesgaming

closes #141
@bors
Copy link
Contributor

bors bot commented Feb 9, 2018

Build succeeded

@bors bors bot merged commit 5018051 into master Feb 9, 2018
@ignatenkobrain
Copy link
Contributor

I actually thought that you would reuse serde feature ;)

@ignatenkobrain
Copy link
Contributor

Also it has std, so you at least should change std = [] → std = [sha1/std] or something like that

@kinggoesgaming
Copy link
Member Author

I can create a separate pr for that.. That was outside the scope of the issue

@kinggoesgaming kinggoesgaming deleted the sha1-0_5 branch February 9, 2018 15:19
@kinggoesgaming kinggoesgaming mentioned this pull request Feb 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radix radix radix approved these changes

@KodrAus KodrAus KodrAus approved these changes

@Dylan-DPC-zz Dylan-DPC-zz Dylan-DPC-zz approved these changes

Assignees

@kinggoesgaming kinggoesgaming

Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

sha1 0.5
5 participants
@kinggoesgaming @Dylan-DPC-zz @KodrAus @ignatenkobrain @radix