Add minimum supported rustc version #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
requested review from
Dylan-DPC-zz,
kinggoesgaming and
radix
as code owners
|
Why did you specifically pick 1.18? Just curious |
|
It was a bit of an arbitrary decision, it's a release that I think most package managers support. |
|
We need to check with some package managers before going for it, just to be sure |
|
1.18 is old enough for most crate owners to release a new version. I have seen a lot of crates keep 1.18 as their min dependency which is fine imo |
kinggoesgaming
approved these changes
Feb 9, 2018
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Feb 9, 2018
143: Add minimum supported rustc version r=Dylan-DPC a=KodrAus Specifically test against `rustc 1.18.0` so we know when we regress the minimum supported version. Personally, I'm ok with pushing the minimum version as a non-breaking change, but it's always good to know and communicate in the release notes.
bors bot
added a commit
that referenced
this pull request
Feb 9, 2018
143: Add minimum supported rustc version r=Dylan-DPC a=KodrAus Specifically test against `rustc 1.18.0` so we know when we regress the minimum supported version. Personally, I'm ok with pushing the minimum version as a non-breaking change, but it's always good to know and communicate in the release notes.
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Feb 9, 2018
143: Add minimum supported rustc version r=Dylan-DPC a=KodrAus Specifically test against `rustc 1.18.0` so we know when we regress the minimum supported version. Personally, I'm ok with pushing the minimum version as a non-breaking change, but it's always good to know and communicate in the release notes.
|
bors: r+ |
|
Not awaiting review |
|
bors r- |
Canceled |
Dylan-DPC-zz
approved these changes
Feb 9, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 9, 2018
143: Add minimum supported rustc version r=kinggoesgaming a=KodrAus Specifically test against `rustc 1.18.0` so we know when we regress the minimum supported version. Personally, I'm ok with pushing the minimum version as a non-breaking change, but it's always good to know and communicate in the release notes.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically test against
rustc 1.18.0so we know when we regress the minimum supported version. Personally, I'm ok with pushing the minimum version as a non-breaking change, but it's always good to know and communicate in the release notes.