Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bytemuck support #711

Merged
merged 4 commits into from Oct 18, 2023
Merged

Added bytemuck support #711

merged 4 commits into from Oct 18, 2023

Conversation

John-Toohey
Copy link
Contributor

This pull request adds support for the bytemuck crate, hence fixing my earlier feature request, issue #710.

@KodrAus
Copy link
Member

KodrAus commented Oct 17, 2023

Thanks for the PR @John-Toohey! I think our big-endian tests in CI are going to fail here for reasons unrelated to your PR. I'll fix those up separately.

Would it be possible to add bytemuck to the list of dependencies we check here too? Otherwise this looks good to me!

@KodrAus
Copy link
Member

KodrAus commented Oct 17, 2023

I've merged #712 which should get CI back to green here. I think all we need to do is add bytemuck to our dependency list here and this should be good to go.

This is so that it is easier to find and more consistent with the
other optional dependencies
@John-Toohey
Copy link
Contributor Author

I have added bytemuck to the CI file; and have added bytemuck to the lib.rs documentation for easy discoverability

Copy link
Member

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @John-Toohey! This looks good to me.

@KodrAus KodrAus merged commit b8ebdee into uuid-rs:main Oct 18, 2023
20 checks passed
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Oct 19, 2023
Bumps uuid from 1.4.1 to 1.5.0.

Release notes
Sourced from uuid's releases.

1.5.0
What's Changed

Add impl From for String under the std feature flag by @​brahms116 in uuid-rs/uuid#700
Remove dead link to templates by @​KodrAus in uuid-rs/uuid#704
make ClockSequence wrap correctly by @​fef1312 in uuid-rs/uuid#705
Track MSRV in Cargo.toml by @​KodrAus in uuid-rs/uuid#706
Support converting between Uuid and vec by @​KodrAus in uuid-rs/uuid#703
Replace MIPS with Miri and add clippy to CI by @​KodrAus in uuid-rs/uuid#712
Added bytemuck support by @​John-Toohey in uuid-rs/uuid#711
Prepare for 1.5.0 release by @​KodrAus in uuid-rs/uuid#713

New Contributors

@​brahms116 made their first contribution in uuid-rs/uuid#700
@​fef1312 made their first contribution in uuid-rs/uuid#705
@​John-Toohey made their first contribution in uuid-rs/uuid#711

Full Changelog: uuid-rs/uuid@1.4.1...1.5.0



Commits

e68b010 Merge pull request #713 from uuid-rs/cargo/1.5.0
b1cc27a prepare for 1.5.0 release
b8ebdee Merge pull request #711 from John-Toohey/bytemuck
2dad70d Added the bytemuck optional dependency to lib.rs documentation
bcf2b58 Added Bytemuck to .github/workflows/ci.yml::env::DEP_FEATURES
a8d2e1d Merge pull request #712 from uuid-rs/ci/miri-clippy
0c5b2df fix up a clippy warning
1d4bd6e Merge pull request #703 from uuid-rs/feat/convert-to-vec
52b3fbc replace MIPS with Miri and add clippy to CI
3833d09 Make the bytemuck dependency look more like the other dependencies
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants