Fix Makefile and stdbuf #1084
Merged
Fix Makefile and stdbuf #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Arcterus what with those test faults? I don't remember where from they come |
|
I'm not sure at the moment. I am going to check either tomorrow or the day after. |
|
Any update on the fix? |
|
@mssun I've been busy with school for the past month and haven't had much free time. I'm hoping to get this fixed either this or next weekend. |
|
Good, thank you. |
|
AFAICT, the issue is the same as in #1095. It seems running |
|
Everything should be fixed now other than the issues with |
|
@mpkh I think this can be merged unless you have any suggestions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this should solve issues #1072, #1064, and #1040. It's a little fragile as it depends on the structure of stuff that
cargogenerates. I also have not tested the build for Macs as I do not have one accessible at the moment.