Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross build targeting Redox to Travis CI #1095

Merged
merged 2 commits into from Dec 10, 2017

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Nov 14, 2017

It is helpful to make sure things are building on Redox, though It's understandable if you don't want Redox breaking CI.

I ran cargo update since Redox required newer versions of a dependency or two.

@nathanross
Copy link
Contributor

@ids1024 Can you clarify what part of this is breaking the CI, and why fixing it is not achievable? I can dig through this later today and take a look on the "why" myself, but the second question would be better answered by you. Thanks!

@ids1024
Copy link
Contributor Author

ids1024 commented Nov 15, 2017

It looks like the cargo update bumped clap, which changed some messages slightly; I don't know if that's the only issue.

@Arcterus
Copy link
Collaborator

I think adding this is a good idea, but maybe we should allow the Redox build to fail for now?

@ids1024
Copy link
Contributor Author

ids1024 commented Nov 16, 2017

maybe we should allow the Redox build to fail for now?

That seems reasonable.

@Arcterus
Copy link
Collaborator

Arcterus commented Dec 5, 2017

@ids1024 can you rebase this?

@ids1024
Copy link
Contributor Author

ids1024 commented Dec 9, 2017

I rebased, but there seem to be some test failures. I think it's due to changes to the CI environment caused by adding sudo: true (which was necessary to install Debian packages, specifically the Redox toolchain).

@Arcterus Arcterus merged commit 9316fb4 into uutils:master Dec 10, 2017
@Arcterus
Copy link
Collaborator

I think those failures were already present due to changes in the standard library. Thanks for rebasing!

@ids1024
Copy link
Contributor Author

ids1024 commented Dec 10, 2017

Ah, I hadn't checking if they were happening on master. Thanks, this should be helpful to have, as Redox is currently working on moving to using uutils more.

@Arcterus
Copy link
Collaborator

Oh nice, that's great to hear!

@jackpot51
Copy link
Collaborator

Yep, the BINS variable here https://github.com/redox-os/cookbook/blob/master/recipes/uutils/recipe.sh identifies which programs we are currently using from uutils. We will continue to contribute to port others.

@Arcterus
Copy link
Collaborator

Arcterus commented Dec 15, 2017

Let us know if you run into any issues and we’ll try to fix them quickly. :)

@jackpot51
Copy link
Collaborator

Good to hear XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants