-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(cp) implement -P/--no-deference #1528
Conversation
23b064b
to
eb43bd2
Compare
@Arcterus rebased and green :) |
f07992e
to
813e57d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the unwrap()
s and some overallocation.
9efd6d8
to
173a79a
Compare
@Arcterus I squashed the two patches into the previous one in case you are ok to merge without the last fix |
dde63bf
to
2ee61ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good other than the one function I mentioned. If resolve_relative_path
doesn’t work for some reason, I’m fine with merging this as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good other than the one function I mentioned. If resolve_relative_path
doesn’t work for some reason, I’m fine with merging this as-is.
@Arcterus all green, ready to be merged! |
@Arcterus ok with you? |
No description provided.