feature(cp) implement -P/--no-deference - #1528
Merged
Merged
Conversation
calixteman
reviewed
May 30, 2020
rivy
removed their request for review
June 5, 2020 02:06
Contributor
Author
|
@Arcterus rebased and green :) |
rivy
force-pushed
the
master
branch
4 times, most recently
from
June 15, 2020 04:39
f07992e to
813e57d
Compare
Arcterus
suggested changes
Jun 16, 2020
Arcterus
left a comment
Arcterus
left a comment
Collaborator
There was a problem hiding this comment.
Looks good other than the unwrap()s and some overallocation.
Contributor
Author
|
@Arcterus I squashed the two patches into the previous one in case you are ok to merge without the last fix |
Arcterus
reviewed
Jun 20, 2020
Arcterus
reviewed
Jun 20, 2020
Arcterus
left a comment
Arcterus
left a comment
Collaborator
There was a problem hiding this comment.
Things look good other than the one function I mentioned. If resolve_relative_path doesn’t work for some reason, I’m fine with merging this as-is.
Arcterus
reviewed
Jun 20, 2020
Arcterus
left a comment
Arcterus
left a comment
Collaborator
There was a problem hiding this comment.
Things look good other than the one function I mentioned. If resolve_relative_path doesn’t work for some reason, I’m fine with merging this as-is.
Contributor
Author
|
@Arcterus all green, ready to be merged! |
Arcterus
reviewed
Jun 20, 2020
Contributor
Author
|
@Arcterus ok with you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.