Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(cp) implement -P/--no-deference #1528

Merged
merged 2 commits into from Jun 24, 2020
Merged

feature(cp) implement -P/--no-deference #1528

merged 2 commits into from Jun 24, 2020

Conversation

sylvestre
Copy link
Sponsor Contributor

No description provided.

@sylvestre sylvestre requested review from rivy and Arcterus May 31, 2020 08:47
@rivy rivy removed their request for review June 5, 2020 02:06
@sylvestre sylvestre force-pushed the cp-no-deref branch 5 times, most recently from 23b064b to eb43bd2 Compare June 9, 2020 11:46
@sylvestre
Copy link
Sponsor Contributor Author

@Arcterus rebased and green :)

@rivy rivy force-pushed the master branch 4 times, most recently from f07992e to 813e57d Compare June 15, 2020 04:39
Arcterus
Arcterus requested changes Jun 16, 2020
View reviewed changes
Copy link
Collaborator

@Arcterus Arcterus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the unwrap()s and some overallocation.

src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved
src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved
src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved
src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved
src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved
src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved
@sylvestre sylvestre force-pushed the cp-no-deref branch 2 times, most recently from 9efd6d8 to 173a79a Compare June 18, 2020 21:44
@sylvestre
Copy link
Sponsor Contributor Author

@Arcterus I squashed the two patches into the previous one in case you are ok to merge without the last fix

Arcterus
Arcterus reviewed Jun 20, 2020
View reviewed changes
src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved
@sylvestre sylvestre force-pushed the cp-no-deref branch 2 times, most recently from dde63bf to 2ee61ea Compare June 20, 2020 07:48
Arcterus
Arcterus reviewed Jun 20, 2020
View reviewed changes
Copy link
Collaborator

@Arcterus Arcterus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good other than the one function I mentioned. If resolve_relative_path doesn’t work for some reason, I’m fine with merging this as-is.

src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved
Arcterus
Arcterus reviewed Jun 20, 2020
View reviewed changes
Copy link
Collaborator

@Arcterus Arcterus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good other than the one function I mentioned. If resolve_relative_path doesn’t work for some reason, I’m fine with merging this as-is.

@sylvestre
Copy link
Sponsor Contributor Author

@Arcterus all green, ready to be merged!
thanks again

@sylvestre
Copy link
Sponsor Contributor Author

@Arcterus ok with you?

@Arcterus Arcterus merged commit 700d51a into uutils:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcterus Arcterus Arcterus requested changes

@calixteman calixteman calixteman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sylvestre @Arcterus @calixteman