uu+tests: use strip_prefix and strip_suffix #2726
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2719
I opened this as a draft because of this:
coreutils/src/uucore/src/lib/features/mode.rs
Lines 167 to 173 in d72a135
I don't really see the benefit of using strip_prefix here since the prefix is already known to be there. IMO it would just add more complexity.
Once someone responds to this I will either remove the comment or implement it using strip_prefix