Initial implementation of `stty` #3672

tertsdiepraam · 2022-06-25T20:51:39Z

I got annoyed that there was no stty yet, so I started working on it :)

In this initial version:

~~Only binary flags are implemented (i.e. attributes that are enabled and disabled). This means that attributes like tabN where N is a number between 0 and 3 is missing.~~ This is now supported.
--all is implemented.
-F/--file and -g/--save are ignored.
Special characters, special settings and combined settings are missing.
The nix crate is used (not libc). Sadly, here are already some attributes that seem to be missing in nix.

The tests are broken on my machine with the error:

thread 'main' panicked at 'Could not get terminal attributes: ENOTTY', src/uu/stty/src/stty.rs:83:44

So the stdout in cargo test does not seem to be a tty with terminal attributes. This might mean that we can't test stty at all? I'd like to try to find a workaround though.

sylvestre · 2022-06-26T07:53:42Z

wahou, amazing :)

anastygnome · 2022-06-28T13:04:16Z

@tertsdiepraam can we use crossterm for this (or are we using it ?)

Maybe we will have to use shell scripts for that TTY issue.

https://docs.rs/crossterm/latest/crossterm/index.html

Wahou indeed (pardon my french interjections ;)

tertsdiepraam · 2022-06-28T14:03:53Z

I'm not currently using crossterm, but nix, which has support for most of the flags that we need for this. crossterm seems to be more about writing to the terminal than changing it's characteristics. The terminal size could come in handy but crossterm doesn't seem to support setting the size. So I'm afraid it will have to stay as low level as it is.

anastygnome · 2022-06-28T14:10:21Z

@tertsdiepraam I thought so as well, but maybe it could be an inspiration for which calls we should use.

src/uu/stty/src/stty.rs

tertsdiepraam · 2022-07-02T17:25:12Z

I've ignored the tests that need to be run from a tty for now, but added some for the argument parsing. I've also added the special settings for the terminal (baudrate, columns, rows and line), but they can only be printed for now (not changed). With those changes this is at least ready to be considered somewhat of a viable first version, though of course there is much to be done :)

tertsdiepraam · 2022-07-02T23:52:59Z

Apparently it needs some work on mac. It will take me a while to fix it though. If someone else wants to fix it up for mac, feel free to do so in the meantime.

anastygnome · 2022-07-03T10:45:13Z

@tertsdiepraam I belive mac os has no support for the cline field in termios.

Hence, should we ignore it ?

I believe the same problem is the cause for the other errors

tertsdiepraam · 2022-07-03T10:48:36Z

Yeah I think that makes sense. The other issue with mac is that the baudrate is represented with a u32 instead of the baudrate enum.

anastygnome · 2022-07-03T11:01:29Z

src/uu/stty/src/stty.rs

+fn print_terminal_size(termios: &Termios, opts: &Options) -> nix::Result<()> {
+    let speed = cfgetospeed(termios);
+    for (text, baud_rate) in BAUD_RATES {
+        if *baud_rate == speed {


if *baud_rate as u32 == speed as u32

seems to work on my system and should fix this issue, unless there are speeds above 32 bits unsigned integers ??

src/uu/stty/src/flags.rs

src/uu/stty/src/stty.rs

fix another flag

tertsdiepraam · 2022-08-19T10:43:34Z

Okay, so I think it's correct now. I can't test with mac, but I get the correct speed on FreeBSD. There are of course some minor issues and missing functionality with this implementation, but I think we can merge this and I can start opening issues for those.

sylvestre · 2022-08-19T10:49:07Z

sounds good, let's wait for the CI :)
I can do more testing on mac if you need

tertsdiepraam · 2022-08-19T12:13:47Z

I'm not sure what's going on with the Cargo.lock format. I can't find anything important that has changes with respect to main.

sylvestre · 2022-08-20T07:34:32Z

Bravo !
would you like to do a release now? :)

tertsdiepraam · 2022-08-20T09:50:56Z

Yes, I'll start working on it!

anastygnome reviewed Jul 2, 2022

View reviewed changes

src/uu/stty/src/stty.rs Outdated Show resolved Hide resolved

tertsdiepraam force-pushed the stty branch from 713eff4 to 42746b5 Compare July 2, 2022 17:22

tertsdiepraam marked this pull request as ready for review July 2, 2022 17:22

tertsdiepraam force-pushed the stty branch from 42746b5 to f9d6b7c Compare July 2, 2022 17:28

anastygnome reviewed Jul 3, 2022

View reviewed changes

sylvestre mentioned this pull request Jul 3, 2022

Stty test #3691

Closed

sylvestre reviewed Jul 6, 2022

View reviewed changes

src/uu/stty/src/flags.rs Show resolved Hide resolved

sylvestre reviewed Jul 6, 2022

View reviewed changes

src/uu/stty/src/stty.rs Show resolved Hide resolved

sylvestre force-pushed the stty branch 2 times, most recently from 6ef0967 to 678fa8b Compare July 11, 2022 20:51

sylvestre force-pushed the stty branch from 678fa8b to a0e9834 Compare August 13, 2022 23:01

tertsdiepraam force-pushed the stty branch 5 times, most recently from 39d1770 to a8d8228 Compare August 16, 2022 10:59

tertsdiepraam added 6 commits August 18, 2022 11:33

starting work on stty

600cab0

add some simple tests to stty (still failing)

a23702c

stty: add grouped flags

4cda8f3

test_stty: fix spell checker errors

6896a85

stty: fix ixany and iutf8 not sane

0c44fc0

stty: fix clippy warnings

96ea772

tertsdiepraam and others added 7 commits August 18, 2022 11:33

stty: fix setting grouped flags

eac8802

stty: disallow combining settings with --all and --save

679fd23

stty: expand --help information

cc147a7

stty: print special terminal information

f861fc0

stty: make compatible with Rust pre 1.61

420c69a

stty: fix bsd/mac builds

85e6f86

Adjust the code after uutils#3832

6f6784f

sylvestre force-pushed the stty branch from 25316ae to 6f6784f Compare August 18, 2022 09:33

tertsdiepraam added 2 commits August 19, 2022 12:37

stty: add cfg guards for flags that don't exist on BSD

0e14e1d

fix another flag

stty: fix nix version

a1250ec

tertsdiepraam force-pushed the stty branch 2 times, most recently from 546e24c to a1250ec Compare August 19, 2022 10:42

stty: cargo fmt

c269a38

Update clap from 3.2.15 to 3.2.17

afda6be

sylvestre merged commit 8786bb6 into uutils:main Aug 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial implementation of `stty` #3672

Initial implementation of `stty` #3672

tertsdiepraam commented Jun 25, 2022 •

edited

sylvestre commented Jun 26, 2022

anastygnome commented Jun 28, 2022 •

edited

tertsdiepraam commented Jun 28, 2022

anastygnome commented Jun 28, 2022

tertsdiepraam commented Jul 2, 2022

tertsdiepraam commented Jul 2, 2022

anastygnome commented Jul 3, 2022 •

edited

tertsdiepraam commented Jul 3, 2022

anastygnome Jul 3, 2022 •

edited

tertsdiepraam commented Aug 19, 2022

sylvestre commented Aug 19, 2022

tertsdiepraam commented Aug 19, 2022

sylvestre commented Aug 20, 2022

tertsdiepraam commented Aug 20, 2022

Initial implementation of stty #3672

Initial implementation of stty #3672

Conversation

tertsdiepraam commented Jun 25, 2022 • edited

sylvestre commented Jun 26, 2022

anastygnome commented Jun 28, 2022 • edited

tertsdiepraam commented Jun 28, 2022

anastygnome commented Jun 28, 2022

tertsdiepraam commented Jul 2, 2022

tertsdiepraam commented Jul 2, 2022

anastygnome commented Jul 3, 2022 • edited

tertsdiepraam commented Jul 3, 2022

anastygnome Jul 3, 2022 • edited

Choose a reason for hiding this comment

tertsdiepraam commented Aug 19, 2022

sylvestre commented Aug 19, 2022

tertsdiepraam commented Aug 19, 2022

sylvestre commented Aug 20, 2022

tertsdiepraam commented Aug 20, 2022

Initial implementation of `stty` #3672

Initial implementation of `stty` #3672

tertsdiepraam commented Jun 25, 2022 •

edited

anastygnome commented Jun 28, 2022 •

edited

anastygnome commented Jul 3, 2022 •

edited

anastygnome Jul 3, 2022 •

edited