Simplify invalid encoding handling #3832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InvalidEncodingHandling
foruucore::Args
was introduced (for good reason) in #1852, but seemed to be unnecessarily complex. A few things stuck out to me:Panic
variant can be removed.accept_any
(and notaccept_lossy
oraccept_complete
)accept_any
is used, then the intermediateConversionResult
is useless and can be removed.collect_str
was overly complex and becomes much nicer when split into two smaller methods.This cleans up a lot, but I don't think it's quite done yet. In particular:
collect_ignore
, but I didn't want to go through every util that does this (which are 23 utils) to check :)Vec
and instead create anIterator
.uucore::Args
does not requireExactSizeIterator
, requiring collecting it into aVec
to get the length, like in Useclap::ArgAction
intrue
andfalse
#3784.