-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use clap::ArgAction
in true
and false
#3784
Conversation
true
and false
clap::ArgAction
in true
and false
Seems like using |
Oh that's unfortunate. Could you make an issue in the clap repo with a minimal reproduction? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not ready
On second thought, I wonder if exclusive is the right thing to do here. Maybe we should just check whether the the number of arguments (i.e. argc) is 2 and check for |
Given the outcome of the issue on clap, I think my previous comment is the right way forward. |
I've reimplemented the behaviour using argument count instead of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Closes #3769