-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more
: reduce memory usage a bit
#6399
base: main
Are you sure you want to change the base?
Conversation
GNU testsuite comparison:
|
272bf32
to
109d4ec
Compare
109d4ec
to
ce29ac5
Compare
GNU testsuite comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you do something like src/uu/shuf/BENCHMARKING.md
and write down how exactly you measure our progress?
For this PR it's obvious that this should reduce memory consumption, so it should be trivial to prove it. For future PRs, I'm afraid that an "optimization" worsens our memory consumption and we don't notice it.
GNU testsuite comparison:
|
Changes since last push:
Nothing to improve performance, but cleans up a bit. |
Clippy is unhappy:
|
@tertsdiepraam ping ? :) |
Work towards (but definitely does not close): #6397
This just reduces the number of strings that are allocated. We're still at 5x the file though. Even though technically, we don't need to keep the file in memory at all.