Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use quick_error in most of programs #6453

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Use quick_error in most of programs #6453

wants to merge 9 commits into from

Conversation

sylvestre
Copy link
Sponsor Contributor

A few still need to be done

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

GNU testsuite comparison:

GNU test failed: tests/ln/sf-1. tests/ln/sf-1 is passing on 'main'. Maybe you have to rebase?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@tertsdiepraam
Copy link
Member

Ow I actually disagree with this... quick_error seems a bit unmaintained. I like thiserror better, but I'd prefer to get rid of both. I don't think they really pull their weight over just implementing Display and From.

@tertsdiepraam
Copy link
Member

But, at the very least we should choose between using quick_error or thiserror and not have both in our dependency tree like we do now. So in that sense I agree with this.

@sylvestre
Copy link
Sponsor Contributor Author

happy to move to thiserror
I didn't realize that quick_error wasn't maintained

@cakebaker cakebaker mentioned this pull request Jun 19, 2024
Merged
@sylvestre sylvestre marked this pull request as draft August 13, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @tertsdiepraam