Add last Utility #65

Puffy1215 · 2024-07-15T15:26:39Z

I implemented the last utility in #18.

Limitations

I only implemented support for Unix
Several flags from GNU last were not implemented.
There are some slight output differences between GNU last and this implementation. They can be easily cleared up given more time. For example GNU last prints the relative time since the last crash, while this doesn't do that quite yet.

Tests
I added some tests too to go along with the PR. They are kind of simplistic though in that they only do a check to verify there was some output. The timestamp checks only do a simplistic regex check on the output.

sylvestre · 2024-07-15T15:48:24Z

src/uu/last/Cargo.toml

+
+# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+


Suggested change

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

sylvestre · 2024-07-15T15:53:08Z

src/uu/last/src/platform/unix.rs

+
+        // "%b %e %H:%M"
+        let time_format: Vec<time::format_description::FormatItem> =
+            time::format_description::parse(description).unwrap();


why not handling the error ? unwrap seems risky, no ? :)

sylvestre · 2024-07-15T15:53:12Z

src/uu/last/src/platform/unix.rs

+        // "%b %e %H:%M"
+        let time_format: Vec<time::format_description::FormatItem> =
+            time::format_description::parse(description).unwrap();
+        ut.login_time().format(&time_format).unwrap() // LC_ALL=C


sylvestre · 2024-07-15T15:59:22Z

src/uu/last/src/platform/unix.rs

+            if counter >= self.limit && self.limit > 0 {
+                break;
+            }
+            // println!("|{}| |{}| |{}|", ut.user(), time_string(&ut), ut.tty_device());


please remove the comments

sylvestre · 2024-07-17T11:58:24Z

i guess you saw it but the builds are failing

Puffy1215 · 2024-07-17T12:07:43Z

i guess you saw it but the builds are failing

Windows and macOS is still broken. I'll work on fixing those. I will also fix the still existing linting issues.

codecov · 2024-07-17T14:42:17Z

Codecov Report

Attention: Patch coverage is 49.85994% with 179 lines in your changes missing coverage. Please review.

Project coverage is 60.05%. Comparing base (6c383c3) to head (a249bc5).
Report is 9 commits behind head on main.

Files	Patch %	Lines
src/uu/last/src/platform/unix.rs	39.24%	150 Missing and 28 partials ⚠️
src/uu/last/src/last.rs	95.23%	0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (6c383c3) and HEAD (a249bc5). Click for more details.

HEAD has 2 uploads less than BASE

Flag BASE (6c383c3) HEAD (a249bc5)

macos_latest 1 0

windows_latest 1 0

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   69.35%   60.05%   -9.30%     
==========================================
  Files          14       18       +4     
  Lines        1142     1467     +325     
  Branches      164      233      +69     
==========================================
+ Hits          792      881      +89     
- Misses        336      460     +124     
- Partials       14      126     +112

Flag	Coverage Δ
macos_latest	`?`
ubuntu_latest	`60.05% <49.85%> (-3.82%)`	⬇️
windows_latest	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Puffy1215 · 2024-07-22T14:23:07Z

It looks like I have everything working now. The existing errors appear to be from other utilities.

failures:
    test_mountpoint::test_invalid_arg
    test_rev::test_invalid_arg

The GitHub runner images do not contain "still logged in" as no user logs into the system. Processes are only running, so only "still running" is present.

GitHub's Linux images only have "still running". The MacOS images have "still logged in". The regex check was changed to account for both options.

sylvestre · 2024-07-24T22:30:01Z

dunno if it is hard to do but could you please add tests with an invalid /var/log/wtmp to check that the error management is properly done ? thanks

Puffy1215 · 2024-07-29T13:32:05Z

dunno if it is hard to do but could you please add tests with an invalid /var/log/wtmp to check that the error management is properly done ? thanks

Added one test so far that matches the behavior with the linux org implementation. That seems like the only test I could get working so far. There were some discrepancies I noticed that I think are beyond my implementation, and involve the UtmpxIter code.

For example, if you have a file of arbitrary bytes (Say a file of one long string of all 'a' characters) which can fit into Utmpx struct, the linux org implementation is able to read it into the fields and display it. However, with our implementation, it does not load any of them into a struct, and so displays nothing.

sylvestre · 2024-08-01T20:19:14Z

a bunch of jobs are failing, could you please have a look?

Like:


error: length comparison to zero
   --> src/uu/last/src/platform/unix.rs:190:16
    |
190 |             if ut_stack.len() == 0 {
    |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ut_stack.is_empty()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
    = note: `-D clippy::len-zero` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::len_zero)]`

error: useless conversion to the same type: `i64`
   --> src/uu/last/src/platform/unix.rs:275:62
    |
275 |         let time = time::OffsetDateTime::from_unix_timestamp(secs.into())
    |                                                              ^^^^^^^^^^^ help: consider removing `.into()`: `secs`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

error: useless conversion to the same type: `u64`
   --> src/uu/last/src/platform/unix.rs:277:36
    |
277 |             + Duration::from_nanos(nsecs.into());
    |                                    ^^^^^^^^^^^^ help: consider removing `.into()`: `nsecs`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `uucore::utmpx::time::OffsetDateTime`
   --> src/uu/last/src/platform/unix.rs:284:13
    |
284 |             OffsetDateTime::from(time).replace_offset(offset) + Duration::from_secs(offset_secs);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `OffsetDateTime::from()`: `time`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

sylvestre reviewed Jul 15, 2024

View reviewed changes

sylvestre force-pushed the main branch from 9a03632 to a59a41f Compare July 24, 2024 22:26

Puffy1215 added 20 commits July 25, 2024 00:27

Add the initial implementation of the last utility

24226ad

tests: Added tests for last util

bfccc75

last: Reformatted unix.rs

05e9658

last: Fixed time formatting issues

1c7712c

last: Fixed missing "- crash" message

8145989

last: Removed wtmp check in test

833b974

last: Fixed documentation and help output

e5dd318

last: Removed unused imports

8814999

last: Added licensing to files

f3b9603

last: Remove unneeded comment from Cargo.toml

8f806ac

last: Replace unwrap with unwrap_or_default

16b9502

last: Remove unneeded comment from test

637cb2e

last: Remove unused variable and is_quoted function

c2db04f

last: Fix clippy warnings

435621f

last: Simplified last test case

464b20c

The GitHub runner images do not contain "still logged in" as no user logs into the system. Processes are only running, so only "still running" is present.

last: Fix Cargo formatting errors

d426da0

last: Limit Unix module to just Unix

33ce621

last: Generalized regex test

78706c8

GitHub's Linux images only have "still running". The MacOS images have "still logged in". The regex check was changed to account for both options.

last: Account for unsupported Windows module

b9a58d5

last: Remove macOS from -x test

b4087a7

sylvestre force-pushed the main branch from a59a41f to b4087a7 Compare July 24, 2024 22:27

Puffy1215 added 2 commits July 29, 2024 21:19

Added earliest timestamp message in output

9772719

Added test_short_invalid_utmp_file

afd6056

Puffy1215 and others added 4 commits July 29, 2024 21:35

Linted code (unix.rs and test_last.rs) to standard

a780ab4

Fixed file start time to use correct formatting. Optimized

ba754ae

Fixed regex in test. Added str constants for time formatting

e412c1f

Merge branch 'main' into main

a249bc5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add last Utility #65

Add last Utility #65

Puffy1215 commented Jul 15, 2024

sylvestre Jul 15, 2024

sylvestre Jul 15, 2024

sylvestre Jul 15, 2024

sylvestre Jul 15, 2024

sylvestre commented Jul 17, 2024

Puffy1215 commented Jul 17, 2024

codecov bot commented Jul 17, 2024 •

edited

Loading

Puffy1215 commented Jul 22, 2024 •

edited

Loading

sylvestre commented Jul 24, 2024

Puffy1215 commented Jul 29, 2024

sylvestre commented Aug 1, 2024


		# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

Add last Utility #65

Are you sure you want to change the base?

Add last Utility #65

Conversation

Puffy1215 commented Jul 15, 2024

sylvestre Jul 15, 2024

Choose a reason for hiding this comment

sylvestre Jul 15, 2024

Choose a reason for hiding this comment

sylvestre Jul 15, 2024

Choose a reason for hiding this comment

sylvestre Jul 15, 2024

Choose a reason for hiding this comment

sylvestre commented Jul 17, 2024

Puffy1215 commented Jul 17, 2024

codecov bot commented Jul 17, 2024 • edited Loading

Codecov Report

Puffy1215 commented Jul 22, 2024 • edited Loading

sylvestre commented Jul 24, 2024

Puffy1215 commented Jul 29, 2024

sylvestre commented Aug 1, 2024

codecov bot commented Jul 17, 2024 •

edited

Loading

Puffy1215 commented Jul 22, 2024 •

edited

Loading