Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable filter and display no stories in “Browse stories” if user has… #333

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

jennifer-lu
Copy link
Member

… no approved languages

Notion ticket link

Disable filter and display no stories in “Browse stories” if user has no approved languages

Implementation description

  • Disable filter and display "No Stories Found" box on browse stories page if user has no approved languages for translation or review

Steps to test

  1. Sign up as someone new or login as someone with no approved languages
  2. Click on browse stories tab
  3. Observe no filters and "No Stories Found" box
  4. Please check that other tabs still work
  5. Please check that browse stories tab still works for users with approved languages (e.g. Dwight Translator English (US))

What should reviewers focus on?

  • Does it work
  • Does the code look ok

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • For backend changes, I have run the appropriate linters: docker exec -it planet-read_py-backend_1 /bin/bash -c "black . && isort --profile black ." and I have generated new migrations: flask db migrate -m "<your message>"
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

>
<Text>No Stories Found</Text>
<Text>Please check access permissions.</Text>
</Flex>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed css and replaced with Chakra for "No Stories Found" box.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 112c75e):

https://planet-read-uwbp--pr333-bug-no-approved-ebqoed0v.web.app

(expires Thu, 20 Jan 2022 21:35:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Contributor

@gaoxk gaoxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! ty for dealing with left over linting issues

@jennifer-lu jennifer-lu merged commit c768711 into main Jan 13, 2022
@jennifer-lu jennifer-lu deleted the bug/no-approved branch January 13, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants