[Fix] No guardian on delete (#297)

* [Fix] No guardian on delete * Change delete to disconnect
uwblueprint · Jul 30, 2023 · 3452442 · 3452442
1 parent 0b520fa
commit 3452442
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/lib/application-processing/resolvers.ts b/lib/application-processing/resolvers.ts
@@ -321,7 +321,7 @@ export const completeApplication: Resolver<
                 },
               },
             },
-            // If guardian information given, upsert. Otherwise, delete (SET NULL)
+            // If guardian information given, upsert.
             ...(guardian
               ? {
                   guardian: {
@@ -331,7 +331,11 @@ export const completeApplication: Resolver<
                     },
                   },
                 }
-              : { guardian: { delete: true } }),
+              : {
+                  guardian: {
+                    disconnect: true,
+                  },
+                }),
           },
         });
 

diff --git a/tools/hooks/graphql.ts b/tools/hooks/graphql.ts
@@ -35,15 +35,12 @@ const useMutation = <
     onCompleted: data => {
       for (const key in data) {
         const result = data[key] as unknown as { ok: boolean; error?: string };
-        if ('ok' in result && 'error' in result) {
-          if (!result.ok) {
-            toast({
-              status: 'error',
-              description: result.error,
-              isClosable: true,
-            });
-          }
-        }
+        if (result.ok) continue;
+        toast({
+          status: 'error',
+          description: result.error,
+          isClosable: true,
+        });
       }
       options?.onCompleted && options.onCompleted(data);
     },