[Fix] No guardian on delete #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherryhli
reviewed
Jun 18, 2023
| @@ -331,7 +331,7 @@ export const completeApplication: Resolver< | |||
| }, | |||
| }, | |||
| } | |||
| : { guardian: { delete: true } }), | |||
| : {}), | |||
There was a problem hiding this comment.
Should we still account for the case where there was previously a guardian, but the new application does not contain a guardian? There should still be a delete right?
There was a problem hiding this comment.
Addressed this case by adding disconnect.
There was a problem hiding this comment.
From what I understand this removes the mapping between the permit and the guardian, but there will be an orphaned guardian in the DB right? Ideally that should be cleaned up too.
sherryhli
approved these changes
Jul 30, 2023
leogjhuang
added a commit
that referenced
this pull request
Jul 30, 2023
* [Fix] No guardian on delete * Change delete to disconnect
leogjhuang
added a commit
that referenced
this pull request
Jul 30, 2023
* Allow numbers in MSP (#296) * [Fix] Broken contact us link (#298) * change nam and address spacing to absolute instead of floating (#300) * Go to applicationProcessing instead of application (#301) * update shopify version to undeprecated one (#302) * Fix bash command for Windows (#299) * Update shopify-buy in yarn.lock (#303) * [Fix] No guardian on delete (#297) * Update processing fee from $26 to $31 (#305) * [Feature] Support search by permit ID on Permit Holders page (#307) * Change pdf address spacing from 1.5 to 1.4 (#306)
leogjhuang
added a commit
that referenced
this pull request
Jul 31, 2023
* Allow numbers in MSP (#296) * [Fix] Broken contact us link (#298) * change nam and address spacing to absolute instead of floating (#300) * Go to applicationProcessing instead of application (#301) * update shopify version to undeprecated one (#302) * Fix bash command for Windows (#299) * Update shopify-buy in yarn.lock (#303) * [Fix] No guardian on delete (#297) * Update processing fee from $26 to $31 (#305) * [Feature] Support search by permit ID on Permit Holders page (#307) * Change pdf address spacing from 1.5 to 1.4 (#306) * [Fix] Update form links to reflect new processing fee (#309)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Unable to create a new permanent permit for an existing temporary permit user
Unable to create a new temporary permit for an existing temporary permit user
Implementation description
Notes
Checklist
[Feature],[Improvement]or[Fix],