Feature/frontend build files cleanup #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@achen2401 When you get a chance, could you fix the merge conflicts? Thanks! |
…g/true_nth_usa_portal into feature/frontend-build-files-cleanup
|
@ivan-c Ivan, conflict should be resolved. I did try this out again in my instance just to make sure the build processes (e.g. frontend files and translations) run successful. But let me know if you see or run into any issue. |
ivan-c
requested changes
Apr 15, 2019
ivan-c
approved these changes
Apr 16, 2019
There was a problem hiding this comment.
Looks good! Merge whenever you're ready @achen2401 (wasn't sure if still WIP)
achen2401
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address TN-1952
address security vulnerability warnings generated when building frontend files. Run
npm auditwill give details as to what they are and what packages are affected.Changes include:
remove unused packages from package json
upgrade gulp to version 4 as version 4 addressed vulnerabilities as listed from running audit
note, this is a breaking change as syntax changes are involved for specifying a task to run.
@ivan-c Ivan, do you want to give this a try and see if anything breaks for you?
One thing I had to do is to do a clean up existing installs
npm prune --productionand then remove the node_modules folder completely - before proceeding to do a rebuild. This is to prevent incompatible packages (i.e. for gulp) to coexist.do not merge yet