-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/frontend build files cleanup #3101
Conversation
@achen2401 When you get a chance, could you fix the merge conflicts? Thanks! |
…g/true_nth_usa_portal into feature/frontend-build-files-cleanup
@ivan-c Ivan, conflict should be resolved. I did try this out again in my instance just to make sure the build processes (e.g. frontend files and translations) run successful. But let me know if you see or run into any issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a few suggestions; i18n changes generally look good (ready to merge), I'll let you know if I find any regressions from Warren's testing
Thanks for taking the time to clean this up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Merge whenever you're ready @achen2401 (wasn't sure if still WIP)
address TN-1952
address security vulnerability warnings generated when building frontend files. Run
npm audit
will give details as to what they are and what packages are affected.Changes include:
remove unused packages from package json
upgrade gulp to version 4 as version 4 addressed vulnerabilities as listed from running audit
note, this is a breaking change as syntax changes are involved for specifying a task to run.
@ivan-c Ivan, do you want to give this a try and see if anything breaks for you?
One thing I had to do is to do a clean up existing installs
npm prune --production
and then remove the node_modules folder completely - before proceeding to do a rebuild. This is to prevent incompatible packages (i.e. for gulp) to coexist.do not merge yet