IRONN-210 allow for change of withdrawal dates #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @pbugni! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
grr, the select for review didn't go through last night, sorry 'bout that. |
mcjustin
approved these changes
Oct 6, 2023
pbugni
added a commit
that referenced
this pull request
Oct 16, 2023
to an int. This worked fine in SQL queries, but the change introduced in PR #4343 requires an int to match research studies in looking for old consents.
pbugni
added a commit
that referenced
this pull request
Oct 16, 2023
The withdrawal API (at /api/user/<id>/consent/withdraw) didn't cast incoming JSON `research_study_id` value to an int. This had previously worked fine in SQL queries, but the change introduced in PR #4343 requires an int to match research studies in looking for old consents.
pbugni
added a commit
that referenced
this pull request
Jan 23, 2024
…#4356) When an exception is raised from any code during the use of a TimeoutLock, it propagates to the `TimeoutLock.__exit__()` method, which must catch and disband the exception, less it'll remain in a potential deadlock state. But, the code attempting to log the exception text was incorrectly accessing the attributes from the stack. This PR corrects to generate a stack in the log file, and move on. This is an old issue, and has been hiding errors raised behind TimeoutLocks from the log files for some time. Is also probably the reason celery will occasionally behave as if it's in a locked state. Finally found a reproduction (while working on #4343 regression issues), and found a solution! I should add, the code in our system protected by TimeoutLocks is SIGNIFICANT - most all questionnaire bank work, building OrganizationTree in memory, EMPRO state manipulation, Adherence Reports, etc.
pbugni
added a commit
that referenced
this pull request
Mar 6, 2024
reverts bug introduced by #4343 , which incorrectly started using the oldest (not most recent) user_consent as last valid consent prior to withdrawal. includes migration to clean up problem cases. required careful re-assessment of consent/withdrawal dates for a number of patients found to have qb_timeline revisions after applying patch above. see https://movember.atlassian.net/browse/IRONN-210 for more detail. NB: #4363 merges into this branch, to be done prior to merging this PR. --------- Co-authored-by: Justin McReynolds <mcjustin@uw.edu> Co-authored-by: Ivan Cvitkovic <ivanc@uw.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for an update to an existing withdrawn consent. Previously, a 404 was generated if the user didn't have a valid matching consent when a withdrawal was requested.
It is required that the requested withdrawal date is: