Hotfit/user consent withdrawal date regression #4358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @pbugni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-02-07 01:19:20 UTC |
pbugni
force-pushed
the
hotfit/user_consent_withdrawal_date_regression
branch
from
b35f612
to
5810415
Compare
pbugni
force-pushed
the
hotfit/user_consent_withdrawal_date_regression
branch
from
65cf04b
to
d6a1f4d
Compare
… for better reuse.
… order - the user of `acceptance_date` assumed the newest date would always be best - that's false logic.
… order - the user of `acceptance_date` assumed the newest date would always be best - that's false logic.
…ents, when looking for consent date after user's consent has been suspended (withdrawn)
…r consent deletion resulted in change
…s completed prior to withdrawal - was reporting status "withdrawn"
… `any_change_noted` check
…s "completion-date"
…e rebuilds for affected patients
pbugni
force-pushed
the
hotfit/user_consent_withdrawal_date_regression
branch
from
0cfe77f
to
5f201e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not ready!!!
reverts bug introduced by #4343 , which incorrectly started using the oldest (not most recent) user_consent as last valid consent prior to withdrawal.
includes migration to clean up problem cases. required careful re-assessment of consent/withdrawal dates for a number of patients found to have qb_timeline revisions after applying patch above. see https://movember.atlassian.net/browse/IRONN-210 for more detail.