Coerce selected Arrow types in vgplot. #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date
objects, rather than numbers.Number
instances, rather thanBigInt
. (FWIW, Plot already does this internally.)These changes apply to unpacking of Arrow tables within vgplot only. We unpack an Arrow table into an array-of-objects format. This was already happening implicitly (using possibly slower Proxy objects); we now do it explicitly with control over type conversions. In the future, if Plot adds support for columnar data we could modify our approach to take advantage of that and reduce data copy costs.
Mosaic client implementations still receive a standard, unaltered Arrow table. This PR targets vgplot mark internals.
Possible future work:
Time
values?Close #155.
Close #176.