Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset search built on select2 #90

Merged
merged 3 commits into from
May 4, 2014
Merged

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented May 3, 2014

@dhalperi
Copy link
Member

dhalperi commented May 3, 2014

Problem with padding on right side when expanded?

screen shot 2014-05-03 at 11 21 49 am

@dhalperi
Copy link
Member

dhalperi commented May 3, 2014

I feel like there's something fishy with the UI. I think I'd prefer not to dropdown, but have the top line disappear when you type. More like github, I guess.
screen shot 2014-05-03 at 11 24 44 am

@dhalperi
Copy link
Member

dhalperi commented May 3, 2014

maybe add : in myria? I can imagine a user wanting this to work:

screen shot 2014-05-03 at 11 23 58 am

Also maybe strip spaces and other things that don't match the regex from the search term?

screen shot 2014-05-03 at 11 26 37 am

@domoritz
Copy link
Member Author

domoritz commented May 3, 2014

Hehe, now that I can try it with the real cluster ;-)

maybe add : in myria? I can imagine a user wanting this to work

Should this be added in the backend or just remove any separator character from the search string?

Also probably strip spaces from the search term?

Agreed

I feel like there's something fishy with the UI. I think I'd prefer not to dropdown, but have the top line disappear when you type. More like github, I guess.

I'm not sure how that would be better. However, highlighting the match should be added.

@dhalperi
Copy link
Member

dhalperi commented May 3, 2014

maybe add : in myria? I can imagine a user wanting this to work

Should this be added in the backend or just remove any separator character from the search string?

I guess I thought users might want to use the : to restrict searches once they have the user or program attribute well enough, which is why I suggested modifying myria.

e.g., on github you can use .sql and that will restrict your search (assuming directories don't have a . in them) to files with s q l in their extension. etc.

@dhalperi
Copy link
Member

dhalperi commented May 3, 2014

I feel like there's something fishy with the UI. I think I'd prefer not to dropdown, but have the top line disappear when you type. More like github, I guess.

I'm not sure how that would be better. However, highlighting the match should be added.

I was thinking that maybe the search box should replace the first row, rather than become the second row. If I hit esc then go back to whatever was in the first row before.

@dhalperi
Copy link
Member

dhalperi commented May 3, 2014

(the github metaphor doesn't really hold up, though. I can't find a filter-like part of their code that actually lets you select other than the file finder, and it's not really a good match).

@dhalperi
Copy link
Member

dhalperi commented May 3, 2014

deployed : fix.

@dhalperi
Copy link
Member

dhalperi commented May 3, 2014

also two more things.

  1. I think I kinda screwed the pooch last night on moving submodules into submodules directory on myria-web master. It all seemed to work just fine for me but now checking out different branches seems to really mess some state up. Sorry!

  2. I'm probably offline most of the rest of the day. :)

@domoritz
Copy link
Member Author

domoritz commented May 3, 2014

I guess I thought users might want to use the : to restrict searches once they have the user or program attribute well enough, which is why I suggested modifying myria.

e.g., on github you can use .sql and that will restrict your search (assuming directories don't have a . in them) to files with s q l in their extension. etc.

Now you can query :adhoc: for example to filter by program name.

  1. I'm probably offline most of the rest of the day. :)

me too ;-)

@domoritz
Copy link
Member Author

domoritz commented May 3, 2014

Alright, I implemented highlighting the matching string parts.

@dhalperi
Copy link
Member

dhalperi commented May 4, 2014

Oh, that's what you meant by "highlighting the match". I like it!

I wish you could annotate images you upload to github with your mouse. I could like circle things, etc. :)

about to 🚢 it

dhalperi added a commit that referenced this pull request May 4, 2014
@dhalperi dhalperi merged commit 8c43647 into master May 4, 2014
@dhalperi dhalperi deleted the domoritz-dataset-search branch May 4, 2014 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants