Add modules listing to the app.src file #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure about this? I'm running the latest rebar, and it still auto-builds the modules attribute. |
|
Weird. Perhaps, you have {validate_app_modules, false} somewhere. Take a look at https://github.com/basho/rebar/blob/master/src/rebar_otp_app.erl#L57 , it uses this validation by default. Come to think of it, maybe instead we should can ask @dizzyd to make this behave in the old style, replacing the default value from 'true' to 'false'. |
|
When using a .app.src file the validation should happen AFTER rebar has generated a list of modules for you. I verified this works as expected just now with current rebar HEAD. This PR is unnecessary. |
|
Ok, thanks, Dizzy. I will follow your recommendation then. |
chenyifan96
pushed a commit
to chenyifan96/gproc
that referenced
this pull request
Jan 20, 2021
trying orbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newest rebar requires modules listing in the app file by default. Also, might be useful for OTP releases.