Add modules listing to the app.src file #10

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@doubleyou
Contributor

Newest rebar requires modules listing in the app file by default. Also, might be useful for OTP releases.

@uwiger
Owner
uwiger commented Nov 16, 2011

Are you sure about this? I'm running the latest rebar, and it still auto-builds the modules attribute.

@doubleyou
Contributor

Weird. Perhaps, you have {validate_app_modules, false} somewhere. Take a look at https://github.com/basho/rebar/blob/master/src/rebar_otp_app.erl#L57 , it uses this validation by default.

Come to think of it, maybe instead we should can ask @dizzyd to make this behave in the old style, replacing the default value from 'true' to 'false'.

@dizzyd
dizzyd commented Nov 17, 2011

When using a .app.src file the validation should happen AFTER rebar has generated a list of modules for you. I verified this works as expected just now with current rebar HEAD.

This PR is unnecessary.

@uwiger
Owner
uwiger commented Nov 17, 2011

Ok, thanks, Dizzy. I will follow your recommendation then.

@uwiger uwiger closed this Nov 17, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment