Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otp21: adapt get_stacktrace calls for OTP21 #29

Merged
merged 4 commits into from
Jul 13, 2018
Merged

Conversation

fenollp
Copy link
Contributor

@fenollp fenollp commented Jun 8, 2018

Since a fix for #28 is coming up in final version of OTP 21 this month let's fix the compilation warnings ahead of time.

Said warnings:

===> Verifying dependencies...
===> Compiling parse_trans
src/parse_trans.erl:129: Warning: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace
src/parse_trans.erl:326: Warning: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace
src/parse_trans.erl:346: Warning: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace
src/parse_trans.erl:737: Warning: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace
src/parse_trans.erl:868: Warning: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace
src/parse_trans.erl:874: Warning: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace
src/parse_trans.erl:874: Warning: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace

Note: I can move the line endings of all files from DOS to just \n with a simple command. Want me to open a PR with that? It would make git blame harder though.

@ferd
Copy link

ferd commented Jun 19, 2018

@uwiger any way to get this merged & on hex?

@getong
Copy link
Contributor

getong commented Jul 11, 2018

@fenollp I make a pr on your branch, and I think use OTP_REALSESE macro is much better.
fenollp#1 , use it if you like it.

@uwiger
Copy link
Owner

uwiger commented Jul 12, 2018

Sorry about the delay. It looks good, but I haven't had time to test it yet. I could merge on good faith, of course ... :-/

@fenollp
Copy link
Contributor Author

fenollp commented Jul 12, 2018

Maybe it’s time to activate some free CI service ;)

@uwiger
Copy link
Owner

uwiger commented Jul 12, 2018

@fenollp absolutely! The main problem re. parse_trans is that there isn't much in terms of automated tests to run. I'd happily accept contributions in that area. ;-)

@fenollp
Copy link
Contributor Author

fenollp commented Jul 13, 2018

@uwiger added a commit that adds TravisCI that just runs a compilation step. I ruled out R15 & R16 as these don't build.

You can see the build passing at https://travis-ci.org/fenollp/parse_trans/builds/403457699

I can bump the app's version if that's easier to publish to hex for you :)

run rebar3 eunit in travis

By adding a `test` profile that at least compiles the `examples` code, CI is improved a bit more.
@fenollp
Copy link
Contributor Author

fenollp commented Jul 13, 2018

Tests pass!

@uwiger uwiger merged commit 76abb34 into uwiger:master Jul 13, 2018
@uwiger
Copy link
Owner

uwiger commented Jul 13, 2018

Thanks!

@uwiger
Copy link
Owner

uwiger commented Jul 13, 2018

Tagged with version 3.3.0 and published to hex

@fenollp fenollp deleted the otp21 branch July 13, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants