Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tamil Language support #2119

Merged
merged 3 commits into from
Feb 9, 2017
Merged

Tamil Language support #2119

merged 3 commits into from
Feb 9, 2017

Conversation

abuabdul
Copy link
Contributor

@abuabdul abuabdul commented Feb 9, 2017

Q A
Bug fix? no
New feature? yes, Tamil Language Translation
BC breaks? no
Related tickets no
License Apache License v2.0

Demo:
http://b2oplus.org/bootstrap-datepicker/

.gitignore Outdated
@@ -4,6 +4,7 @@ docs/_build
# OS or Editor folders
.DS_Store
.idea
*.iml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Will do.

@acrobat
Copy link
Member

acrobat commented Feb 9, 2017

Hi @abuabdul, Thanks for the translation only one comment left to fix!

@abuabdul
Copy link
Contributor Author

abuabdul commented Feb 9, 2017

@acrobat I have fixed it.

@acrobat acrobat merged commit d97106c into uxsolutions:master Feb 9, 2017
@acrobat
Copy link
Member

acrobat commented Feb 9, 2017

Thanks @abuabdul

@Azaret
Copy link
Contributor

Azaret commented Feb 10, 2017

I believe that at the moment we enforce usage of ISO 639-1 unless we want to add a variant or a language for a specific country.
I won't speculate for the usage of Tamil, but:

  • if there is officially only one Tamil dialect
  • or if there is no significant differences between any Tamil dialects in general or in the particular context of this date picker (rewording: if the result of various Tamil dialects of this translated file result the same)
  • or if the Indian Tamil is largely the most used of the Tamil dialects,

Then we should rename the file and internal name to ta.

@acrobat
Copy link
Member

acrobat commented Feb 11, 2017

Thanks @Azaret for the feedback! I've renamed the locale file in 9f5e9a5

@Azaret
Copy link
Contributor

Azaret commented Feb 12, 2017

Well I would have a word from @abuabdul on this 😄

@acrobat
Copy link
Member

acrobat commented Feb 12, 2017

Yeah I was a bit quick with the changes. I'm going to revert my commit for now and wait for the feedback from @abuabdul. If the locale key needs to change we can do it in a 1.7.x release!

@abuabdul
Copy link
Contributor Author

abuabdul commented Mar 7, 2017

Hi, I guess @Azaret is right. The translation will be mostly same if other dialects like Malaysian Tamil or Colombo Tamil did translate. The dialects of Tamil could be different regionally but the calendar translation is same since it is a Gregorian. So i will agree to rename. Thanks @Azaret.

@acrobat let me know if you want me to rename the file.

@acrobat
Copy link
Member

acrobat commented Mar 8, 2017

@abuabdul Yeah if you also agree that the locale code should be 'TA' then please create a PR to rename the file and locale code in the file. Thanks!

@Azaret
Copy link
Contributor

Azaret commented Mar 9, 2017

What a mess @acrobat 😋
I'm gonna PR this.
Ty for your help @abuabdul !

@acrobat
Copy link
Member

acrobat commented Mar 9, 2017

Yeah, I'm sorry :D Thanks @Azaret and @abuabdul

acrobat added a commit that referenced this pull request Mar 9, 2017
Fix Tamil Language file with proper locale code, see #2119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants