Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation amendment #2645

Closed
digdilem opened this issue Sep 24, 2020 · 12 comments
Closed

Minor documentation amendment #2645

digdilem opened this issue Sep 24, 2020 · 12 comments
Assignees
Labels
bug Something isn't working docs documentation

Comments

@digdilem
Copy link
Contributor

Following "Server - Minor Upgrade" section of

https://www.uyuni-project.org/doc/2020.09/uyuni_upgrade_guide.pdf

This did not upgrade on my installation. The Uyuni repo was not automatically refreshed.

Suggestion:

Include an additional step between stage 1. and 2. of

  1. Refresh the uyuni repository

zypper ref

@paususe
Copy link
Contributor

paususe commented Oct 1, 2020

@keichwa
Could you please implement this change?

@keichwa keichwa self-assigned this Oct 1, 2020
@keichwa
Copy link
Contributor

keichwa commented Oct 1, 2020

Thanks for the report!

keichwa added a commit to uyuni-project/uyuni-docs that referenced this issue Oct 14, 2020
* Add info about refreshing software repositories
uyuni-project/uyuni#2645
SUSE/spacewalk#12612
* default settings do not require 'zypper ref'.
* Update modules/upgrade/pages/server-minor-upgrade-uyuni.adoc
Co-authored-by: Lana Brindley <lbrindley@suse.de>
* also add note about autorefresh and zypper ref
@mcalmer mcalmer added the bug Something isn't working label Oct 29, 2020
@paususe
Copy link
Contributor

paususe commented Feb 14, 2021

@keichwa it seems this was added to the docs, so closing the issue.

@paususe paususe closed this as completed Feb 14, 2021
@keichwa
Copy link
Contributor

keichwa commented Feb 17, 2021

yes, thanks for closing!

@juliogonzalez
Copy link
Member

@keichwa this is now reported at the list as missing: https://lists.opensuse.org/archives/list/users@lists.uyuni-project.org/message/6PACXIDHGBZZGUM32LTR6QUBG4YQPU6P/

Can you have a look?

@keichwa keichwa reopened this Oct 5, 2021
@keichwa
Copy link
Contributor

keichwa commented Oct 5, 2021

I guess it was removed because we have this note after the procedure:

[NOTE]
====
By default, zypper refreshes the repository every ten minutes (see ``repo.refresh.delay`` in [path]``/etc/zypp/zypp.conf``).
If ``autorefresh`` is disabled, run [command]``zypper ref`` to refresh all repositories.
====

I think it would be save if I'd add zypper ref as an OPTIONAL step, and move the note to a place before the procedure. @juliogonzalez would this work?

@digdilem
Copy link
Contributor Author

digdilem commented Oct 5, 2021 via email

@juliogonzalez
Copy link
Member

@digdilem @keichwa I agree with just instructing the user to call zypper ref as a "full step", meaning we will not really need a note.

@keichwa is there any particular reason you want to have it as optional and keep the note?

@keichwa
Copy link
Contributor

keichwa commented Oct 5, 2021 via email

@juliogonzalez
Copy link
Member

I see mlandres was pretty clear there:

So if you know all enabled repos have autorefresh on, you don't need an explicit refresh. Otherwise you do (unless you know the repos do not contribute to the command).

But even if we specify zypper ref for SUSE Manager as well... what's exactly the problem? The refresh does not download all the metadata if it didn't change, it only checks if it needs to download it.

keichwa added a commit to uyuni-project/uyuni-docs that referenced this issue Oct 5, 2021
uyuni-project/uyuni#2645
leaving out this step causes more trouble than good.
@keichwa
Copy link
Contributor

keichwa commented Oct 5, 2021

Yes, agreed. The step is back: uyuni-project/uyuni-docs#1213
I'll keep the note nevertheless; if we want to remove it, we can create a separate PR.

keichwa added a commit to uyuni-project/uyuni-docs that referenced this issue Oct 11, 2021
uyuni-project/uyuni#2645
leaving out this step causes more trouble than good.
keichwa added a commit to uyuni-project/uyuni-docs that referenced this issue Oct 11, 2021
uyuni-project/uyuni#2645
leaving out this step causes more trouble than good.
keichwa added a commit to uyuni-project/uyuni-docs that referenced this issue Oct 12, 2021
* in upgrade guide, add "zypper ref" step (#1213)

uyuni-project/uyuni#2645
leaving out this step causes more trouble than good.
@keichwa
Copy link
Contributor

keichwa commented Oct 12, 2021

merged

@keichwa keichwa closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs documentation
Projects
None yet
Development

No branches or pull requests

5 participants