-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify packages index with best checksum algorithm #2290
Verify packages index with best checksum algorithm #2290
Conversation
b82cdba
to
d0dc6c2
Compare
d0dc6c2
to
e5aa882
Compare
Iterating over checksum algorithms, the best that is available is used to do the verification. It is not needed to repeat the checksum verification with weaker algorithms afterwards. Fixes uyuni-project#2283
Raising this exception was removed in 536787d and the test now fails 100% of the time.
e5aa882
to
d8d04f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks 👍
I just did a manual test first without, then with this patch applied. In the "before" run I got the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What does this PR change?
Iterating over checksum algorithms, the best that is available is used
to do the verification. It is not needed to repeat the checksum
verification with weaker algorithms afterwards.
GUI diff
No difference.
Documentation
No documentation needed: Just a bugfix
DONE
Test coverage
I am not sure if
backend/common/test/test_repo.py
is executed anywhere, I had to change the import path everywhere and only ran the test from a particular directory. I think it makes more sense to clean the execution up than commit my additional test as is.Links
Fixes #2283
Changelogs
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: