Changed MenuTree Names (bsc#1019847) #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncounter
approved these changes
Oct 30, 2018
Yes, I won't merge until I got a successful testrun - thanks for the quick review |
juliogonzalez
approved these changes
Oct 30, 2018
|
After some adjustments for uyuni the UI-changes work fine with the testsuite. |
amannch
force-pushed
the
master-bsc1019847
branch
from
d2d2814
to
5ec9387
Compare
added 3 commits
November 7, 2018 12:54
Updated localization Strings for the Menu on the left hand side of the web UI. This is an attempt to remove redundant and/or duplicate names so that it is easier to navigate the site for the user
Changes entry names to run with changes made in commit: 9720f2261ae3c9300ed117d38c5ee2385fae8762
amannch
force-pushed
the
master-bsc1019847
branch
from
5ec9387
to
2e9b268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Updated localization Strings for the Menu on the
left hand side of the web UI.
This is an attempt to remove redundant
names so that it is easier to navigate
the site for the user.
This PR is ported from https://github.com/SUSE/spacewalk/pull/5929
GUI diff
See https://github.com/SUSE/spacewalk/pull/5929
Documentation
#271
Test coverage
No Errors on local testsuite for 3.1
Uyuni-testsuite couldn't be run due to postgres errors when creating an activation key.
(Seems to be unrelated to the changes in this PR)
https://github.com/SUSE/spacewalk/issues/5854
https://bugzilla.suse.com/show_bug.cgi?id=1019847
Relevant branches (GitHub automatic links expected below):
Uyuni
DONE