Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration for latest obs-to-maven #2689

Merged
merged 2 commits into from Oct 7, 2020

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Oct 5, 2020

What does this PR change?

The latest obs-to-maven doesn't depend on osc anymore. However this
introduces a few changes in the configuration file.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: tooling

  • DONE

Test coverage

  • No tests: tooling change

  • DONE

Links

Changelogs

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_lint_checkstyle"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_oracle"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@cbosdo cbosdo requested review from mcalmer and renner October 5, 2020 14:22
@cbosdo cbosdo added the java label Oct 5, 2020
Copy link
Member

@renner renner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! 👍

Could we summarize that there is 3 potential layers to be specified: artifact, package and jar, while rpm is gone now? If all of those are equal, it seems sufficient to specify artifact and repository (e.g. in the case of jcommon). Otherwise if the package name differs from the artifact name, it can be given as package, and I assume jar if there is more than one jar file produced by a package. Looking at httpclient though, jar is equal to artifact, couldn't it be omitted in such a case?

Copy link
Member

@renner renner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it seems you already made the jar attribute obsolete if it is equal to artifact 👍

The latest obs-to-maven doesn't depend on osc anymore. However this
introduces a few changes in the configuration file.
Since obs-to-maven doesn't require osc anymore, there is no longer the
need to mount oscrc in the container.
@cbosdo cbosdo merged commit 56263b6 into uyuni-project:master Oct 7, 2020
@cbosdo cbosdo deleted the obs-maven-noosc branch October 7, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants