New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spacecmd with no parameters produces a traceback on SLE 11 SP4 (bsc#1176823) #2718
Conversation
…ient (bsc#1176823)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @vzhestkov !
Only thing missing here is to add a changelog message to the corresponding spacecmd.changes
file.
Rememeber about the changelog message and to backport. |
Thanks for the fix, Victor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog entry looks good, remember about the backports :-)
And just for the record: it is safe to ignore the java_lint_checkstyle test. |
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
#2669 What does this PR change?
Fixes syntax issue for Python 2.6 used in SLE 11 SP4 and keeps the functionality the same.
Before:
traceback on running spacecmd with no parameters on SLE 11 SP4
After:
normal behavior
Fixes https://bugzilla.suse.com/show_bug.cgi?id=1176823
Changelogs
Re-run a test