Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacecmd with no parameters produces a traceback on SLE 11 SP4 (bsc#1176823) #2718

Merged
merged 3 commits into from Jan 11, 2021

Conversation

vzhestkov
Copy link
Contributor

@vzhestkov vzhestkov commented Oct 14, 2020

#2669 What does this PR change?

Fixes syntax issue for Python 2.6 used in SLE 11 SP4 and keeps the functionality the same.

Before:
traceback on running spacecmd with no parameters on SLE 11 SP4

After:
normal behavior

Fixes https://bugzilla.suse.com/show_bug.cgi?id=1176823

Changelogs

  • No changelog needed

Re-run a test

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_oracle"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Member

@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @vzhestkov !

Only thing missing here is to add a changelog message to the corresponding spacecmd.changes file.

@juliogonzalez
Copy link
Member

Rememeber about the changelog message and to backport.

@Bischoff
Copy link
Contributor

Thanks for the fix, Victor.

Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry looks good, remember about the backports :-)

@juliogonzalez
Copy link
Member

And just for the record: it is safe to ignore the java_lint_checkstyle test.

@vzhestkov
Copy link
Contributor Author

Changelog entry looks good, remember about the backports :-)

Done 👍

Copy link
Member

@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vzhestkov vzhestkov merged commit 4e1ee55 into uyuni-project:master Jan 11, 2021
@vzhestkov vzhestkov deleted the bsc#1176823 branch January 11, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants