Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: Fix navigation step to Clear SSM button #3759

Merged
merged 1 commit into from May 13, 2021

Conversation

srbarrios
Copy link
Member

What does this PR change?

Fixing a navigation step to click on Clear SSM button.
On previous PRs we were starting the scenario from the homepage, that's not any more true, as now we keep the web browser session for the whole session, so we must assure to move to the proper page. In that case, we were finding an element with value "Clear" while we were in a page with a hyperlink that has a text "Clear" so... we had an ambiguity.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed

  • DONE

Test coverage

  • Cucumber tests were changed

  • DONE

Links

Ports:

  • Manager-4.0

  • Manager-4.1

  • DONE

Changelogs

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_oracle"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Contributor

@lkotek lkotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@juliogonzalez juliogonzalez merged commit 5162689 into master May 13, 2021
@juliogonzalez juliogonzalez deleted the qa-fix-nav-clear-ssm branch May 13, 2021 12:57
@github-actions
Copy link
Contributor

⚠️ The changelog has not been updated. Please update it @srbarrios.

@juliogonzalez
Copy link
Member

False positive (again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants