-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove last uses of python3-simplejson in favor of json module #6661
Conversation
@@ -1,3 +1,5 @@ | |||
- Add python3-simplejson dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not explain why this is needed, or what's going to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that we really want this. We explicitely dropped the simplejson
some time ago, as we can use the json
module from the Python3 std lib.
Why not simply removing this conflictive import? https://github.com/uyuni-project/uyuni/blob/master/python/spacewalk/satellite_tools/spacewalk-repo-sync#L25
Co-authored-by: Julio González Gil <juliogonzalez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. LGTM 👍
What does this PR change?
Remove the remaining uses of
python3-simplejson
inspacewalk-repo-sync
andspacewalk-clone-by-date
as reported in the user mailing list.The standard
json
module is used instead.GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: package dependency
DONE
Links
Fixes #
Tracks # add downstream PR, if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: