Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last uses of python3-simplejson in favor of json module #6661

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Feb 27, 2023

What does this PR change?

Remove the remaining uses of python3-simplejson in spacewalk-repo-sync and spacewalk-clone-by-date as reported in the user mailing list.
The standard json module is used instead.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: package dependency

  • DONE

Links

Fixes #
Tracks # add downstream PR, if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@@ -1,3 +1,5 @@
- Add python3-simplejson dependency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not explain why this is needed, or what's going to be fixed.

Copy link
Member

@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that we really want this. We explicitely dropped the simplejson some time ago, as we can use the json module from the Python3 std lib.

Why not simply removing this conflictive import? https://github.com/uyuni-project/uyuni/blob/master/python/spacewalk/satellite_tools/spacewalk-repo-sync#L25

python/spacewalk/spacewalk-backend.changes Outdated Show resolved Hide resolved
utils/spacewalk-utils.changes Outdated Show resolved Hide resolved
Co-authored-by: Julio González Gil <juliogonzalez@users.noreply.github.com>
@cbosdo cbosdo changed the title Add python3-simplejson dependency for repo-sync Remove last uses of python3-simplejson in favor of json module Feb 28, 2023
Copy link
Member

@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. LGTM 👍

@juliogonzalez juliogonzalez merged commit 79554f7 into uyuni-project:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants