Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid conflict names for openSUSE channels #6830

Conversation

juliogonzalez
Copy link
Member

@juliogonzalez juliogonzalez commented Apr 11, 2023

What does this PR change?

Avoid conflict names for openSUSE channels (I was aware that labels could conflict, but not names)

Problem reported at the mailing list: https://lists.opensuse.org/archives/list/users@lists.uyuni-project.org/thread/ALGZ7DZHN3E6ZGI2WDWCOCV35MQJ3OOP/

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: The channel labels are used for spacewalk-common-channel, so this change is not relevant.

  • DONE

Test coverage

  • No tests: We don't have tests for spacewalk-common-channels for now.

  • DONE

Links

Fixes #6831 and fixes https://github.com/SUSE/spacewalk/issues/21043

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Contributor

@raulillo82 raulillo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I could also test it to see that it works!

@juliogonzalez
Copy link
Member Author

LGTM, and I could also test it to see that it works!

Thanks! I asked the user that reported this, to test as well, so I will wait a bit more before merging.

@juliogonzalez
Copy link
Member Author

Merging. @raulillo82 added 15.4 first, 15.5 later and didn't have conflicts. It's the opposite of what the user at the ML did (15.5 first, 15.4 later), so FMPOV the test is valid.

@juliogonzalez juliogonzalez merged commit 698dfc1 into uyuni-project:master Apr 12, 2023
8 checks passed
@juliogonzalez juliogonzalez deleted the leap-channel-names-no-conflict branch April 12, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting name for openSUSE repositories
3 participants